From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EGE7JbL2VWGRXwAAWB0awg (envelope-from ) for ; Thu, 30 Sep 2021 13:41:06 -0400 Received: by simark.ca (Postfix, from userid 112) id 867C51EE28; Thu, 30 Sep 2021 13:41:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D9E2B1EDF7 for ; Thu, 30 Sep 2021 13:41:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8F54F3857C53 for ; Thu, 30 Sep 2021 17:41:05 +0000 (GMT) Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.47.100]) by sourceware.org (Postfix) with ESMTPS id 92CE33858C2C for ; Thu, 30 Sep 2021 17:40:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 92CE33858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway22.websitewelcome.com (Postfix) with ESMTP id E60114375A for ; Thu, 30 Sep 2021 12:40:51 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id W039mpM7btL6eW039m1yiz; Thu, 30 Sep 2021 12:40:51 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GtQwipbIK+IVcKJrOY+Xz4fHtOOzSPchT6tax7B+Npw=; b=HssHtZEMyENlO0vpckxtMha1MR C44ALxrggbpOc9GcD7qNWN2QRCeG7kGy/luxYQU2yVJjovKJNx5bz1uYjebkMu6quJ3BIwPOUQ58I cbRnAzY5yUddxLsyvN56WULLT; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:53932 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mW039-000e4O-Ga; Thu, 30 Sep 2021 11:40:51 -0600 From: Tom Tromey To: Sergio Durigan Junior via Gdb-patches Subject: Re: [PATCH] [PR gdb/28369] Use get_shell on gdb/ser-pipe.c References: <20210925213421.750832-1-sergiodj@sergiodj.net> X-Attribution: Tom Date: Thu, 30 Sep 2021 11:40:49 -0600 In-Reply-To: <20210925213421.750832-1-sergiodj@sergiodj.net> (Sergio Durigan Junior via Gdb-patches's message of "Sat, 25 Sep 2021 17:34:21 -0400") Message-ID: <87h7e20xni.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mW039-000e4O-Ga X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:53932 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sergio Durigan Junior Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Sergio" == Sergio Durigan Junior via Gdb-patches writes: Sergio> PR gdb/28369 reports that gdb/ser-pipe.c has an 'execl' function call Sergio> with a hard-coded "/bin/sh" as its argument. We've had 'get_shell' Sergio> for a while now, which is conscious about the SHELL environment and a Sergio> better alternative to always calling "/bin/sh". Thanks, this is ok. Tom