From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id k8vcKMXX4WEXDgAAWB0awg (envelope-from ) for ; Fri, 14 Jan 2022 15:06:29 -0500 Received: by simark.ca (Postfix, from userid 112) id 954A31F34E; Fri, 14 Jan 2022 15:06:29 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E95AC1EA69 for ; Fri, 14 Jan 2022 15:06:28 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 83A453858033 for ; Fri, 14 Jan 2022 20:06:28 +0000 (GMT) Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 38CCA3858403 for ; Fri, 14 Jan 2022 20:06:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38CCA3858403 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id A239510047538 for ; Fri, 14 Jan 2022 20:06:15 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 8SpznDY9MikTn8Spznp1XO; Fri, 14 Jan 2022 20:06:15 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=CeHNWJnl c=1 sm=1 tr=0 ts=61e1d7b7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=QyXUC8HyAAAA:8 a=k5LS4tMj6IYDRfQAV_MA:9 a=fzgDwW-VyUYA:10:uccc_2email_address a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tY2y6XbJru4uNN3PLDy/X0nXqnnmDwrU+peoSojjLIQ=; b=JpSCvL4GPbbOVJL649Ql7rQb6w /rQrR+jmL5FQXZIwsTnl0iC5+TnVDj5DgO5HTMNAyr0QBy4yn1zFhgQ/R+MfAv5zY2hmRBxyqCIDA P5Duxh6FqxQuAfMx988/VSRx3; Received: from 75-166-134-30.hlrn.qwest.net ([75.166.134.30]:55898 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n8Spy-004ObF-K0; Fri, 14 Jan 2022 13:06:14 -0700 From: Tom Tromey To: Nils-Christian Kempke via Gdb-patches Subject: Re: [PATCH 1/2][PR fortran/26373][PR fortran/22497] gdb/fortran: add support for accessing fields of extended types References: <20220113163909.2880018-1-nils-christian.kempke@intel.com> <20220113163909.2880018-2-nils-christian.kempke@intel.com> X-Attribution: Tom Date: Fri, 14 Jan 2022 13:06:13 -0700 In-Reply-To: <20220113163909.2880018-2-nils-christian.kempke@intel.com> (Nils-Christian Kempke via Gdb-patches's message of "Thu, 13 Jan 2022 17:39:08 +0100") Message-ID: <87h7a6f5fu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.30 X-Source-L: No X-Exim-ID: 1n8Spy-004ObF-K0 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-30.hlrn.qwest.net (murgatroyd) [75.166.134.30]:55898 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernhard Heckel Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> ">" == Nils-Christian Kempke via Gdb-patches writes: >> From: Bernhard Heckel >> Fortran 2003 supports type extension. This patch allows access >> to inherited members by using their fully qualified name as described >> in the Fortran standard. Thanks for the patch. >> In doing so the patch also fixes a bug in GDB when trying to access the >> members of a base class in a derived class via the derived class' base >> class member. >> @@ -2374,6 +2374,12 @@ value_struct_elt (struct value **argp, >> if (v) >> return v; >> + /* Fortran: If it is not a field it is the type name of an inherited >> + structure. */ >> + v = search_struct_field (name, *argp, t, 1); >> + if (v) >> + return v; Putting this here makes me wonder if it's possible to construct test cases in other languages that would work without this patch and then fail with it. I'm not sure what the options are though. Doing the work elsewhere, say in a custom Fortran expression operation, might make the Python API harder to work with. Maybe having value_struct_elt check current_language would work... that's also quite ugly but other value operations are doing that. Or maybe my fears are overblown. Any thoughts on this? Tom