Re: [PATCH 5/5] Handle non-ASCII identifiers in Ada

Eli Zaretskii via Gdb-patches
2022-02-28T19:00:59Z

> Date: Mon, 28 Feb 2022 11:33:04 -0700
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tom Tromey <tromey@adacore.com>
>
> +for c in range(0, 0x10FFFF):
> + process_codepoint(c)

This script assumes that the version of Python which will run it is
up-to-date with the latest Unicode Character Database (UCD), right?
Is that a good assumption? Wouldn't it be better to process the UCD
from the latest Unicode Standard directly?

> +@kindex set ada source-charset
> +Set the source character set for Ada. The character set must be one
> +of the ones supported by GNAT. Because this setting affects the

"must be one of the ones supported" sounds awkward. Can you reword
it?

Other than that, the documentation parts are okay. Thanks.