From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WadXIBfGAWVQhBUAWB0awg (envelope-from ) for ; Wed, 13 Sep 2023 10:24:23 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=vceRaTMu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 75C181E0C3; Wed, 13 Sep 2023 10:24:23 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2F6DE1E028 for ; Wed, 13 Sep 2023 10:24:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D12FA3858C2D for ; Wed, 13 Sep 2023 14:24:20 +0000 (GMT) Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 9AE8D3858D39 for ; Wed, 13 Sep 2023 14:24:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9AE8D3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-6006a.ext.cloudfilter.net ([10.0.30.182]) by cmsmtp with ESMTP id g8PCqixBtDKaKgQmkqu20O; Wed, 13 Sep 2023 14:24:06 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id gQmiqeyx5fOE6gQmjqaAFa; Wed, 13 Sep 2023 14:24:05 +0000 X-Authority-Analysis: v=2.4 cv=Od+LszfY c=1 sm=1 tr=0 ts=6501c605 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=zNV7Rl7Rt7sA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=632-wwmRQbG1kbiz_AoA:9 a=zgiPjhLxNE0A:10 a=ZXulRonScM0A:10 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YSlkPyhSB/KGkTQAgOfNaOe6ckdlUFT370wIwUTfT7c=; b=vceRaTMuumlx4W9UFHvVQtzOgi hrXyulZ345r08VeTxcUTltZhJbmnJYByCG5tzbywPm7vrxD4RCCtHaN3gSPI0UELZCg8PF9ww49Lo TC/WxhTJGJUBeXBytyxt3wHjK; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:36408 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qgQmi-003Hll-1n; Wed, 13 Sep 2023 08:24:04 -0600 From: Tom Tromey To: Kevin Buettner via Gdb-patches Subject: Re: [PATCH] Throw error when creating an overly large gdb-index file References: <20230909025521.3128935-2-kevinb@redhat.com> <87o7i7jrxm.fsf@tromey.com> <20230912194323.7537de96@f37-zws-nv> X-Attribution: Tom Date: Wed, 13 Sep 2023 08:24:02 -0600 In-Reply-To: <20230912194323.7537de96@f37-zws-nv> (Kevin Buettner via Gdb-patches's message of "Tue, 12 Sep 2023 19:43:23 -0700") Message-ID: <87h6nyi22l.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qgQmi-003Hll-1n X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (murgatroyd) [71.211.130.31]:36408 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBERQv12AWdHsQvJB3+zD7P/jSumtkSX8djxkP89ZlcfnZozNtgwjZAWIDR+p+hk74tigWBgUmHqmiRqWNn+mph34TduiyVpO97MZVnPYQ5DHDOnyymB h1rC8h2RO2DQCSsH+g2oGSAfkCLiKh9PzzKYNDOSfl6ZPRiwC2t7o8MB1vJHhn6hdfBPs25Uu+Tr7JZfunUd1VLHVHU+khPqRmo= X-Spam-Status: No, score=-3019.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Kevin" == Kevin Buettner via Gdb-patches writes: Kevin> The shared object is 3 GiB in size and the gdb-index section for it is Kevin> 4.3 GiB in size. Thanks. Kevin> I extracted .debug_str using obj_copy, replaced the \0 characters Kevin> with newlines, and then used sort and uniq on that output. There Kevin> were no duplicate lines. Altogether, there are 1,212,620 strings Kevin> in .debug_str. Kevin> I can't say that I fully understand the layout of the constant pool, Kevin> but it appears that all of the strings from .debug_str will end in the Kevin> latter part of it. So, if I'm right, that alone accounts for nearly Kevin> half the size of the index file. Yeah, putting copies into the constant pool was a mistake; though I think part of my rationale was that often the constant pool will hold different versions -- they go through name canonicalization. Anyway your patch looks good to me. Thank you. Tom