From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zNIxOawTBGfJ9AQAWB0awg (envelope-from ) for ; Mon, 07 Oct 2024 13:00:28 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=MuGXVOv+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BE3241E355; Mon, 7 Oct 2024 13:00:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1D1571E05C for ; Mon, 7 Oct 2024 13:00:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D553B385C6CE for ; Mon, 7 Oct 2024 17:00:27 +0000 (GMT) Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id E5CED3858CDA for ; Mon, 7 Oct 2024 17:00:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E5CED3858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E5CED3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728320410; cv=none; b=SEMDE+WNUaXadA9giA42jvO9eRZnaqW1LBBwEd/eGi3c/HHpqah5hknwrKyCRDpsX1VR1I1PRRngh5azqKJg1mjKFnLntDhRY3ikV3qY0rneNm6x5ZzInmU80LA4Q3v+XxZtl8MDT6oa5pcswe3H4UfuUwSjS0pnSagO4lt95yU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728320410; c=relaxed/simple; bh=Lz0F/wbYW3qNTN5FhSQJtKCTHlkDMqBSrOys7H92RWo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Q3C1wyfxM0mb7MiOyN1y14F9kLNuE15j6YwRW7KKi9w5aNgy7UYZor823b4SRQ3cmUV/gJdTSwYXMkxV/vCJARvrjp6+7LZ4TGqJgdRf+SyTDTN+twGzclEwM9FQkD4fxPtCUfgCfHmBut+njlHGMBc5NO3erVQefsbU+tNBTjw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTPS id xUnXsJLJeqvuoxr5bsRG4q; Mon, 07 Oct 2024 17:00:08 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xr5asJ0Nmjcdmxr5bsED9I; Mon, 07 Oct 2024 17:00:07 +0000 X-Authority-Analysis: v=2.4 cv=DrWd+3/+ c=1 sm=1 tr=0 ts=67041397 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=DAUX931o1VcA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=jAvIVzriDW-TGHxFRIYA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vPVtuKCCL3P+Cnxtali3hQvqOXO3X76smEQxyeRq+68=; b=MuGXVOv+x0Fy/JFsP5FYz8OO1e b5g5m8HPu8RVmRVu7gig5nyXfc/eIzjMdMKl4u9Ea+/ovIFD1SG5yooQUqnP8CUyq+xQy9QCSylnn DKDVJEjXZea0HALGvr2p9Vsf1; Received: from 97-122-122-36.hlrn.qwest.net ([97.122.122.36]:33862 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1sxr5a-002xag-1D; Mon, 07 Oct 2024 11:00:06 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb: make use of set_tdesc_osabi overload in features/ files In-Reply-To: <805ec50236bae86f1e7e1d77ceff99763ec00ba4.1728239729.git.aburgess@redhat.com> (Andrew Burgess's message of "Sun, 6 Oct 2024 19:37:06 +0100") References: <805ec50236bae86f1e7e1d77ceff99763ec00ba4.1728239729.git.aburgess@redhat.com> X-Attribution: Tom Date: Mon, 07 Oct 2024 11:00:05 -0600 Message-ID: <87h69netm2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.122.36 X-Source-L: No X-Exim-ID: 1sxr5a-002xag-1D X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-122-36.hlrn.qwest.net (murgatroyd) [97.122.122.36]:33862 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfF6iquUgy0aXsch01vp3nGWbh8Rl4gdBccl0GIzYWbmoWPjjoh8LOgBSdCnNGt4fFNXkRz2FuVTKuF3O0NtT/tusRo04lUyAdjTnwFZetYcfRphuONQe pUXOHkN/dF+C5H6gc887F1fHDHn5xNQN07dl3b4dbimbzQzugQ1YoZq3XEESLwwYMQX5CUOefXorGabrfkFx12ditOSPC5vSGxM= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> In the gdb/features/ files we call the second of these functions, like Andrew> this: Andrew> set_tdesc_osabi (result.get (), osabi_from_tdesc_string ("GNU/Linux")); Andrew> This can be replaced with a call to the first set_tdesc_osabi Andrew> function, so lets do that. I think that this makes the features/ code Andrew> slightly simpler and easier to understand. Andrew> There should be no user visible changes after this commit. Looks good. Approved-By: Tom Tromey Tom