From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WD9rAmtxBmdAWgcAWB0awg (envelope-from ) for ; Wed, 09 Oct 2024 08:04:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Axhm7n8u; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0255D1E356; Wed, 9 Oct 2024 08:04:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4B19F1E354 for ; Wed, 9 Oct 2024 08:04:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA84C38650E4 for ; Wed, 9 Oct 2024 12:04:57 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 5E934385DDC3 for ; Wed, 9 Oct 2024 12:04:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E934385DDC3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5E934385DDC3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728475480; cv=none; b=SJ+ia75j8MiU8M3d1M7DM+hj51sGXvY1Q5heZpSYv1fcI+IFPfldWVC+viJha2vqy6gVPTq+ZZ5VjFXBRXORgNM7yRqdKp5VpM1saNbciX2NQWBnctfnzlm8jbV2z1g+VUH707xB9v0bYtn2TsoJ9CfVIiReO7+O4pm65PnThpc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728475480; c=relaxed/simple; bh=C3pXOVXDtaDuzqmeAETK9St4HcXUYQRRF2+cvDiHIJ0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hb4OMDZb4rdCAM4xRybxhzDun8TqeSohK3GRzwGOO4FAKDdgDTKWlrU/8YUkYjUaUoPR1nB7sKVUGvE52R9poRvCgDQkTQk8v4i/xIlByI/BvPkjpmG+wnEpxgNbU+8/coVuLJ+mJSYnSCOiYeaIucdjM+IAYuUjOvBNEDgb1JA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728475478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=64E48ekzyVpaWrFD0UPB6kdB2t7oTiqrsgBdEnhVr6Q=; b=Axhm7n8uo/0lcmKgNbveGJJS8KDctVr5DrD8q/q6eHsjo2RQRR35B3EATh7fopn2MKot4u hbzh+0vxPEq9ImCELg7Iw7bPsbakbtzrxxI7UIPFomu+gBcJ7yAKXawjUs5HoxWlQ+jOAZ 6EH3hVXSjeiNQmq3T7/V27H0AjnLWRw= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-xWUDphnKMoiplk4kp0mdug-1; Wed, 09 Oct 2024 08:04:36 -0400 X-MC-Unique: xWUDphnKMoiplk4kp0mdug-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a9940593476so351188366b.3 for ; Wed, 09 Oct 2024 05:04:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728475475; x=1729080275; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=64E48ekzyVpaWrFD0UPB6kdB2t7oTiqrsgBdEnhVr6Q=; b=Q4FSTNWQUvwOx+ebgmwQTgzO5LlNqd4b2zFSEVs2/ePcwi1OwtbP5mFJ3Ajm7rRijY mkUdCDKWYKOtMuxXuffPA7qwIDAWa2K5ZfRqE/VNnSpCrHVLGNI/fZPLEgQz+HCv/625 dge2r/xWBORI5NbNgOMw+3mj0+6gjka4q7yvdja5TlV4OWauVU3j9Zd8NhiwwDpUA9Nn ODgkMCLVOuBAqyYpg9bfR5FX5CG+9Grb422kCUYOm1q0qykfsvl/4W610KwGbr3v3FN3 evRsWE4XLqy2+jJMQnA6g5W+VZbh7bBpJg0vX/lraJqtmnygwYcvfrZIbgHMluGeXuhK AJjQ== X-Forwarded-Encrypted: i=1; AJvYcCU3+ulY8Ond8SQ2+ncBpg9kUmigmqaAkm5WhD/3RJjpwzDjiD7/vEBBGvCUo7FWs8DNFf+HRPvtQGxtQg==@sourceware.org X-Gm-Message-State: AOJu0YyV2puyHhxP2QM9TJjI0lDa718aFQrj02dq6Hrjqe31tBbfFaE8 0A11U2aCid5jFhx+GrDEv9x+mEOmt1FW4Q2L2U366KV1/gt30d3L4Iw9WKh1srQAqsJWb/2SBCs 002brn1Q4IWoWc2e5u28xUznvKaGjZPHIi8rffjfzP0nMpAOK45hKi/XSXyQSCa7TAe4= X-Received: by 2002:a05:6402:3815:b0:5c3:d18e:fc27 with SMTP id 4fb4d7f45d1cf-5c91d722a8emr1700756a12.33.1728475475417; Wed, 09 Oct 2024 05:04:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8AsFnn/dJwU9nAfMziPiqw6YLQtJZt5KYzJWn5tVhh/ugrIIFKA0GDU0x0m9BXqt1hdaIDg== X-Received: by 2002:a05:6402:3815:b0:5c3:d18e:fc27 with SMTP id 4fb4d7f45d1cf-5c91d722a8emr1700728a12.33.1728475474815; Wed, 09 Oct 2024 05:04:34 -0700 (PDT) Received: from localhost ([195.213.152.26]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c8e05ac2casm5395720a12.34.2024.10.09.05.04.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 05:04:34 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb: make use of set_tdesc_osabi overload in features/ files In-Reply-To: References: <805ec50236bae86f1e7e1d77ceff99763ec00ba4.1728239729.git.aburgess@redhat.com> <87jzehbkk0.fsf@redhat.com> Date: Wed, 09 Oct 2024 13:04:33 +0100 Message-ID: <87h69lbhym.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > On 2024-10-09 07:08, Andrew Burgess wrote: >> Simon Marchi writes: >> >>> On 2024-10-06 14:37, Andrew Burgess wrote: >>>> There are two versions of the set_tdesc_osabi function in GDB: >>>> >>>> void >>>> set_tdesc_osabi (struct target_desc *target_desc, const char *name) >>>> { >>>> set_tdesc_osabi (target_desc, osabi_from_tdesc_string (name)); >>>> } >>>> >>>> void >>>> set_tdesc_osabi (struct target_desc *target_desc, enum gdb_osabi osabi) >>>> { >>>> target_desc->osabi = osabi; >>>> } >>>> >>>> In the gdb/features/ files we call the second of these functions, like >>>> this: >>>> >>>> set_tdesc_osabi (result.get (), osabi_from_tdesc_string ("GNU/Linux")); >>>> >>>> This can be replaced with a call to the first set_tdesc_osabi >>>> function, so lets do that. I think that this makes the features/ code >>>> slightly simpler and easier to understand. >>>> >>>> There should be no user visible changes after this commit. >>> >>> Just a nit but... while at it, couldn't we change them to use the >>> enumerator directly, to save lookups at runtime? >>> >>> set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); >>> >>> I guess we would need a enum -> string (GDB_OSABI_LINUX -> >>> "GDB_OSABI_LINUX") function, which we have for other enums. We just >>> don't have it for this enum yet. Another case for adding a "magic enum" >>> library :). >> >> This was Luis' request. See v2 my attempt at this. > > Oh, sorry, I did not see v2 yesterday. I just realised I actually forgot to tag it v2. It starts here: https://inbox.sourceware.org/gdb-patches/cover.1728407374.git.aburgess@redhat.com/T/#u totally my fault. Sorry for that. Thanks, Andrew