From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id x6u8JBQJ8Gje5DUAWB0awg (envelope-from ) for ; Wed, 15 Oct 2025 16:50:28 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=lug+AgzG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8721D1E0BA; Wed, 15 Oct 2025 16:50:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BBC901E047 for ; Wed, 15 Oct 2025 16:50:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6CB323858287 for ; Wed, 15 Oct 2025 20:50:27 +0000 (GMT) Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id B39F73858D1E for ; Wed, 15 Oct 2025 20:50:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B39F73858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B39F73858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760561412; cv=none; b=nItlfcNIYbDDQIsUgXQfsUvicl8vAEH7MaQ22awMQAnxPaptk+yqXls/wxYzaZNhzx5r2AcljoaAQaEfvvzRPPQPjYW2rRASNGg/8nsWVDxEwoG2tQdvbXsF9ToDmsdGWmlnNRv0rAZUOiPNSQADIVeTTZjT2ERQYVvZEeall5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760561412; c=relaxed/simple; bh=2q6+y6eLEwWGmQ/8hKfS4Cbii0wzdfTW1owQeA6Pn70=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XAxkoHCpJHhKE33L1k2zTn4VA3SCBKkLftRaB2ptUyPpXrLf082IQ/GgP0dVGVlDkoQ60KWiwuFgZcj4ec7blMe42JToxefjtikNLYkgimrNLyX7hHFRFvBGlzmdMzQXXSZPVMzF2eWizv/rhkTRMpGd5sHHNQ3p1vMzKMJ7KgY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B39F73858D1E Authentication-Results: sourceware.org; dkim=policy reason="signing key too small" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=lug+AgzG Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id 94cdvw62beNqi98RnvfQKX; Wed, 15 Oct 2025 20:50:11 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 98Rlvc0oAp0Hq98RlvmPSJ; Wed, 15 Oct 2025 20:50:09 +0000 X-Authority-Analysis: v=2.4 cv=H/nbw/Yi c=1 sm=1 tr=0 ts=68f00903 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=x6icFKpwvdMA:10 a=ItBw4LHWJt0A:10 a=pGLkceISAAAA:8 a=zstS-IiYAAAA:8 a=P-JuUCoX9uMWf_CzzYIA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NRJQQrFXo/OyKPxZA7jQqabmEALZi6Iz62yaVrYS87w=; b=lug+AgzGuedMFC8lZ+cUbjUYpy weVJO5GqCLi5gBUhGDykYSFrB9sAVTdHW5d18XSRb71GnkD2Et+jnglJoPVxH4Ip9cLwyC6QTl2ix jlAdhpX9QaCSyrXLRnnYXIE76; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:54904 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1v98Rl-00000003YGC-0LH1; Wed, 15 Oct 2025 14:50:09 -0600 From: Tom Tromey To: William Ferreira Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3] [gdb] Create script to convert old tests into Dwarf::assemble calls. In-Reply-To: <20251012211555.8103-1-wqferr@gmail.com> (William Ferreira's message of "Sun, 12 Oct 2025 18:15:55 -0300") References: <20251012211555.8103-1-wqferr@gmail.com> X-Attribution: Tom Date: Wed, 15 Oct 2025 14:50:07 -0600 Message-ID: <87h5vzsxds.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1v98Rl-00000003YGC-0LH1 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:54904 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLihJgVeVRNk4wm14br5v25pfHwMkMufu1h4Y2Xg3E8UHQr5ISFgGds/lZQjrtSImoxno0iySPFCjDWJWzZosPMHkmqGAFdblHqRDI9K9P3WzL3cRbi6 SPQlEIa/fvSZCYzQ2v2bvpo/mrdtO2ZWnMY7VlL2mL9Q3nR+lIq178iD/hjk07oshqQAiN3NpzVIhFoeK/Vhyx932ycbG1HaXkg= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> William Ferreira writes: > PR testsuite/32261 requests a script that could convert old .S-based > tests (that were made before dwarf.exp existed) into the new > Dwarf::assemble calls in Tcl. This commit is an initial implementation > of such a script. Python was chosen for convenience, and only relies on > a single external library. Thank you for doing this. > The following .exp files have been tried in this way and their outputs > highly resemble the original: > - gdb.dwarf2/dynarr-ptr > - gdb.dwarf2/void-type > - gdb.dwarf2/ada-thick-pointer > - gdb.dwarf2/atomic-type > - gdb.dwarf2/dw2-entry-points (*) > - gdb.dwarf2/main-subprogram Are you planning to try to convert these tests? If so that would be fantastic. If not, that's totally fine, maybe we should file a bug for this. It'd be nice to get rid of the old .s tests. Anyway let me know. > Currently the script has the following known limitations: [...] FWIW I think basically any limitations are fine. The DWARF assembler itself had many at the start, people tend to add things as needed. > + s = lbrace > + s += self.name + " " > + s += self._format_value(offset_die_lookup) I somewhat suspect this output will not work now, because there were some recent changes to make attributes Tcl code rather than specially-parsed data. However that's yet another thing we can fix in situ. Approved-By: Tom Tromey I forget what your copyright situation is. If you are all set up, we can land this. If you plan to submit more gdb contributions, let me know and we can set up write-after-approval access for you. Tom