From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CNtWDFoVYGkaNTMAWB0awg (envelope-from ) for ; Thu, 08 Jan 2026 15:36:42 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FqxnsUrp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 219BD1E0B6; Thu, 08 Jan 2026 15:36:42 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B6CCD1E08D for ; Thu, 08 Jan 2026 15:36:41 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 5F1894BA23C7 for ; Thu, 8 Jan 2026 20:36:41 +0000 (GMT) Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id B1C0A4BA2E29 for ; Thu, 8 Jan 2026 20:36:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B1C0A4BA2E29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B1C0A4BA2E29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767904592; cv=none; b=tNnGsOGkY4rKRQzoi3tpEXdV4lVDThceJ5NM73Ni/XHnoLAtSBtvwnz8wAs272ex3OedvsRZRarqewKeeDQdbRT4JTQ4bBZdHEAL5yEFrS7JE9pPSD6diBZdX5Adeoh34+3vwcEuKGzd38jAkc1HYa59sY4W6OEn6SArgKoOzWw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767904592; c=relaxed/simple; bh=kpxGEt2q0IX824GP4doJq5ZyD6Int3XXne7RiJulRFE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=D/QXN2d4hHjfyJNpWF1redHSP12+ioGhqv5X+mkVOrBitBt+GpN6MVjkg0XUh4mKt3aslclq2XqfM9n/yWa4fBI4K9wGy9PVqBOh4RuiX+zuJQE1Iy7ccWghIvxq76DUKY03m6b9YRZXRpJD7z6Gr6TSm3y6szlKQee3KvJe5eo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id dol6vsuWhipkCdwk9vZGwW; Thu, 08 Jan 2026 20:36:29 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id dwk8vcISHN3K1dwk8vZgLk; Thu, 08 Jan 2026 20:36:29 +0000 X-Authority-Analysis: v=2.4 cv=UdRRSLSN c=1 sm=1 tr=0 ts=6960154d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=RLxl5AQqqsyYAJsRTb0A:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zoIE8GK79bkYO6E7TGTyQF3L8XH2RAvy/Aunsi/350E=; b=FqxnsUrp9szOVf9O9jJWmvypAW Clil8tQK/q7noMIxLG5Z/Tq/KgP66lISsaJaBA2DFzi5A9LyKPrWbWxvI+pe8LxXgLo26cO+gvM54 M8B8m42gBRq7yANimZBvZ85i9; Received: from 75-166-246-134.hlrn.qwest.net ([75.166.246.134]:46484 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vdwk8-000000046RL-1KXq; Thu, 08 Jan 2026 13:36:28 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/8] gdb/xcoffread: remove xcoff_symfile_info::{symtbl, symtbl_num_syms} In-Reply-To: <20260108193507.553779-5-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 8 Jan 2026 14:33:22 -0500") References: <20260108193507.553779-1-simon.marchi@efficios.com> <20260108193507.553779-5-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 08 Jan 2026 13:36:27 -0700 Message-ID: <87h5svon90.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.246.134 X-Source-L: No X-Exim-ID: 1vdwk8-000000046RL-1KXq X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-246-134.hlrn.qwest.net (bapiya) [75.166.246.134]:46484 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLv4GDChqa4Z/cPCgaTr4CC7Ld8DCcUM02YU4EFXF8yk9bTsPy/cVRzcqqbAspJYFKVbKs1Uv165kU4mpzPw2XPCQ6LbJDMFYnG38o6mjzdGR91V1LOb zent5X4gBNJWH5/4Fs7Iwsqjuq7xK2INvKaGE0OUvThQ1S94RL7R3F8LYpzC8vc1VW+MQA5RxNpP7erpvTCRXysYq+bHr3YKgR8= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> It is not necessary to save the symbol table content and number of Simon> symbols in xcoff_symfile_info, because they are only needed for the Simon> duration of scan_xcoff_symtab. Simon> Move the reading of the symbol table content to scan_xcoff_symtab, and Simon> keep everything as local variables. Simon> + /* Seek to symbol table location. */ Simon> + if (int ret = bfd_seek (abfd, symtab_offset, SEEK_SET); Simon> + ret < 0) Simon> + error (_("Error reading symbols from %s: %s"), Simon> + objfile_name (objfile), bfd_errmsg (bfd_get_error ())); 'ret' doesn't really seem to be needed here. Otherwise looks good. Approved-By: Tom Tromey Tom