From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id quFuOphQsGnx9CEAWB0awg (envelope-from ) for ; Tue, 10 Mar 2026 13:10:48 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KrXuw06a; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D39AB1E0DD; Tue, 10 Mar 2026 13:10:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 48BBC1E089 for ; Tue, 10 Mar 2026 13:10:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 38C8A4BA23CC for ; Tue, 10 Mar 2026 17:10:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 38C8A4BA23CC Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KrXuw06a Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id AA2624B9DB6F for ; Tue, 10 Mar 2026 17:10:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA2624B9DB6F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA2624B9DB6F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773162604; cv=none; b=uKXiMp5K5Jgt9tsSWPcYd3g0kO66Fv0Q9uBf/zDCzJy4ReBSLtL0fXBcl9phZbvP5QswdLV090Z6lkbNvBJbJJNyXEg45JOir7ONy5D5M39I9V6wC7TeeecHn2bcUlb1cVlYtK2GfWwq+dudOs88SCizXmuhWYans4JfefDnv78= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773162604; c=relaxed/simple; bh=VEBSp4K0MGRzn0MPQC61riaMxB/mnE21jmqZByuGWVo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xHGdyVF/gAhQLtXMbo+FU+003mj8+V3VAJngVS3sR1coW03TU1XGeUyntZIR0nlfPJzSoe2Fu2svNJlmA1SUanv1BqeYh2VpAnMtei20I5miH/iGv6ot37fg4gYO49M6jeVyYPW7db8d+r8lhyvJFzIAXMqtXuo+J5MG3kzzcNo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA2624B9DB6F Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id zyihv0DSRJ9SZ00aowU5QT; Tue, 10 Mar 2026 17:10:02 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 00aewyzvnh8QW00aewLYgw; Tue, 10 Mar 2026 17:09:52 +0000 X-Authority-Analysis: v=2.4 cv=Mcdsu4/f c=1 sm=1 tr=0 ts=69b0506a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=ecz2QcS30exbcFeNlo0A:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0QW0yvvOwOuiiXl+cbliFuSpLTkmQDFtBmUb8zisESw=; b=KrXuw06aYbZElZ10alLrxKQIdB GWzstoLJUpYRoBOXrPFBc7DxaZVn3SKy5xW2cPR/BpKb8PdJTUmZoDsm8e1f7GxQJV2Me3us1MKBY fdvYjEKfLAmn8auIExcyWPhtZ; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:39096 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w00ad-00000004LaK-3vfM; Tue, 10 Mar 2026 11:09:52 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH v3 7/9] gdb: make expanded_symbols_functions hold compunit symtabs In-Reply-To: (Simon Marchi's message of "Mon, 9 Mar 2026 14:48:34 -0400") References: <20260217195329.3833518-1-simon.marchi@polymtl.ca> <20260228035425.422765-1-simon.marchi@efficios.com> <20260228035425.422765-8-simon.marchi@efficios.com> <87seafo0xu.fsf@tromey.com> X-Attribution: Tom Date: Tue, 10 Mar 2026 11:09:50 -0600 Message-ID: <87h5qnvcf5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1w00ad-00000004LaK-3vfM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:39096 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOZXFMp2zAVGwB4cl7r3XMBqCdPd4KfrDYHZcCGKr51friJ6BtiNFAWQfTuBeOLa567q/ZlwusbnrsfU+L3D57p0YI9nGaQbYye+rAqQsx74fA4Limux 7pTAcyCAKdT+b2xU9w/bzhhfZR/xINsapcF5iZcAkMXfg3e5D30JoY0ACM5jU2BlLQWjrxE2Uo8+M+1MRymkG/kiX9CuVAPAWfU= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> Now, arguably some of these spots aren't really needed in the current >> setup. For instance, objfile relocation in practice is probably not >> needed by the current expanded-symbols users (though it seems a little >> less future-proof to assume this). Simon> I don't understand this. If some code wants to iterate on all compunit Simon> symtabs of a given objfile, it would use objfile::compunits. Why would Simon> changing expanded_symbols_functions affect that? That note was based on a misconception. But anyway I think it would be a better design for the 'quick' subclasses to own their own compunits. Then it would be less possible to accidentally iterate over "other" compunits. Generic code iterating over all compunits is often a bug. Like, it's fine for dumping or for relocation. But searches done this way can be susceptible to the old expansion order problems. Tom