From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdbsupport] Poison ctype.h / cctype functions
Date: Tue, 24 Mar 2026 08:42:56 -0600 [thread overview]
Message-ID: <87h5q570gf.fsf@tromey.com> (raw)
In-Reply-To: <79de1f3b-1ef4-4ced-8f6d-ad1408eab73b@suse.de> (Tom de Vries's message of "Tue, 24 Mar 2026 14:55:00 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> On 3/23/26 3:17 PM, Tom Tromey wrote:
Tom> +POISON_CCTYPE (int isalnum (T c));
Tom> +POISON_CCTYPE (int std::isalnum (T c));
>> I suspect redefining standard functions like this is not allowed in
>> C++.
Tom> That's a pity.
Tom> Then automatically checking this falls in the domain of precommit
Tom> checkers. Maybe I could extend check-gnu-style to include this
Tom> (though this isn't really a GNU style thing I suppose).
Yeah. I considered adding a checker to avoid includes of <ctype.h>
but that doesn't actually prevent the use of these things, because they
can be made visible via other includes anyway.
Tom
prev parent reply other threads:[~2026-03-24 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 16:03 Tom de Vries
2026-03-23 14:17 ` Tom Tromey
2026-03-24 9:05 ` Tom de Vries
2026-03-24 13:28 ` Tom de Vries
2026-03-24 13:55 ` Tom de Vries
2026-03-24 14:42 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5q570gf.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox