From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9vM9J7WE2GkJ6w8AWB0awg (envelope-from ) for ; Fri, 10 Apr 2026 01:03:49 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=SLcLFLvY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 86D651E08C; Fri, 10 Apr 2026 01:03:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 828851E08C for ; Fri, 10 Apr 2026 01:03:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 350614BA2E2D for ; Fri, 10 Apr 2026 05:03:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 350614BA2E2D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=SLcLFLvY Received: from mail-dl1-x1229.google.com (mail-dl1-x1229.google.com [IPv6:2607:f8b0:4864:20::1229]) by sourceware.org (Postfix) with ESMTPS id 6F1664BA2E0F for ; Fri, 10 Apr 2026 05:03:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F1664BA2E0F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F1664BA2E0F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1229 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775797403; cv=none; b=p69ME+pVsaqigScF0m6wyDHzQoSfSm0Gm4eA1quEimErF04NWxvH1FUkm2PEtdthdWvBN6C8lKIZSOY6Lw4dPmOnZyKqfM6FHnpjF5A/4+buqU06W/nefq0w5UN0tBz46ACMKxrB/KmZpaGRlEWv42pBB3E1a0e0vUlih8beC/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775797403; c=relaxed/simple; bh=Owg6GQe5SLJ91t8yj0+4zbN5Bx1a0jbxqlSRO9lxDdE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ELfvfzFMKFE5QNEIjvLAK8/pNTXBSh8BGODzRaDLpys3GVwdFE1Ii5NXaNmuRWaju2Ccxi8yjpUiTL2n/OBvk5SgU7DfH4mXm0i39M5l591muNaT84hfsINbskRFEz+1RF++JDfOXMWitkzgtBBylOigkB9sgM2KOmZuZ4AdlmI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6F1664BA2E0F Received: by mail-dl1-x1229.google.com with SMTP id a92af1059eb24-128b9b7e3edso4271954c88.0 for ; Thu, 09 Apr 2026 22:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775797402; x=1776402202; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=9HsTCJfXs3beglyNIKr78Fts7gUAURfd0hQ7+CgGR40=; b=SLcLFLvYi4OwuteIgJVgGJDc5E5HPAEryzVsHCtVOl2qI/UhZesS9peUR33HNQIv+J B0DahJWaRySPFAAhkDfEVXVICIMxXDHDRdYZ5VKqapve52Gmtf8QYFaot8yVfB52MjqY sL1JvOb5oDWp5ZwCQDyQVUFBl+lEd6LrK1/HkiV5jOvhQ64kw7D0xW6XBljRhLuht+Hj Utu/IN7bsYGjW7Sc5jTsU3mwPWord7O9MxC0hgKrH8v3vE2gsDK81k/2svTyCSpbFxbK O2KhhdPRGKmT36mKIb/MBFchIV00nlJTwkPPJX7jJTFesnQcq7W5dBSdQQQbTr9R9M2K JYEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775797402; x=1776402202; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9HsTCJfXs3beglyNIKr78Fts7gUAURfd0hQ7+CgGR40=; b=KPWiOkZWksiuBSXSHAMJpzJOriDRcn37e5EKXeZ725/PydAQgF5ccH+YrCRLDsYIJn 1Oejt2DVDXW30V8mc1rGZVvglvwpov2wybJGrhQfO2IpC6wt0S8G+Dl+sjvdeEqMO1mE CZr2BxXvZoh2GJalZXdDdGgNPaeC/Ek+HuztMv5XHKm6d/RPY3FF02FuD9JpPGcXxLtr ZY15YwzNbpBc8bFMPhqUbqMgPE+B/F3QrCe1zcVt5VdWg3KYw583NSgUeT5nuTqxsIAS 6OZDeAzc88MEAEMlie6+QbnfjkC1ckaZtPZ2vkBCd8fOsZ1wAiHNv6EmjyrE44TzO6YZ TFZw== X-Gm-Message-State: AOJu0YxMpHc1AoPzRhL2MAto4UWnzD7GI4rrtWevMhlkzoe1OLrNxaF8 cdiZGpQuCYqgCHPztccqvMVURklxzLnENRBtkYOHqL39n8Wk0ao2jCn8z51Ynoq3cF8= X-Gm-Gg: AeBDietl43uv3pH79po7c+knPhq4uEzuFT4Nvx/l31ZUjVdY0f2OAUvOcy+r/2kgwNY slOL+9G4PB4wOoFUwCPQKNbxzFGSM96vH5PXTm6Iz6P/fm3yTVxGtZvdGX1oP4z0dc1BQfBLSNX iMw0SoJKWfRMnBFAIMPFFN+B17WpwhYLvLt7agNj79KbtH1eWHJliPjeh0L+twSIVPe/2xIJ2LV gyaGKz6Tp/Jp4j+K/1qvrtix5/tDhw5VdXoABaOifcTdxW6D/AOZqMjhDb0bwB2zeyZee1qd0vr m+SQyTof5yRTfvS0PqYIVLi+rjHGHCldWxQjhCJ6Dgfl6htddZLt64TD71TOKSL95ZneBcRp6A3 bhTyQe/6/EiFdzNKoN4fa4QHsqDKDkeCNYkJCkUdids3H0rRa65pcdgig5T/dAA+KC5WvaS+H9N kz08z5I7N2Xf2GvFmtX+gKEixFeYVJWB3vI+X46vHu+4pu X-Received: by 2002:a05:7022:618e:b0:12a:713b:8958 with SMTP id a92af1059eb24-12c34e5a827mr1112121c88.10.1775797401962; Thu, 09 Apr 2026 22:03:21 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c3459faa7sm2515040c88.2.2026.04.09.22.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 22:03:21 -0700 (PDT) From: Thiago Jung Bauermann To: "Schimpe, Christina" Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH v2 1/9] gdb: Generalize handling of the shadow stack pointer. In-Reply-To: (Christina Schimpe's message of "Thu, 9 Apr 2026 11:57:26 +0000") References: <20260123080532.878738-1-christina.schimpe@intel.com> <20260123080532.878738-2-christina.schimpe@intel.com> <871phxzlzr.fsf@linaro.org> <87tsuty5ih.fsf@linaro.org> User-Agent: mu4e 1.14.0; emacs 30.2 Date: Fri, 10 Apr 2026 02:03:19 -0300 Message-ID: <87h5pj1k6g.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hello Christina, "Schimpe, Christina" writes: > Thank you for sharing the patch and the review. > > I wonder if we should we split this commit into 2 separate ones: > #1 "aarch64: Implement gdbarch function top_addr_empty_shadow_stack." > #2 "gdb: Generalize handling of the shadow stack pointer." > > This way you could be the author of patch #2, and I'll add my self as co-author > since I'll also move my changes from aarch64-linux-tdep.c into this patch. > > With the commit "gdb: Generalize handling.." only, the GCS unwinding logic is > still functional and will be generalized in the aarch64 specific patch. > > I'll also include the patch in my v3 then. > > What do you think? I don't mind the patch the way it is now, but if you think splitting is better, that sounds good to me too. As you mention, the main thing is to keep existing functionality working between each patch to help with bisection. -- Thiago