From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Improve gdb.src/pre-commit.exp
Date: Tue, 21 Jul 2026 11:43:24 -0600 [thread overview]
Message-ID: <87h5lsutkz.fsf@tromey.com> (raw)
In-Reply-To: <20260717122756.51352-1-tdevries@suse.de> (Tom de Vries's message of "Fri, 17 Jul 2026 14:27:56 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> This allows us to get rid of the current SKIP kludge for the pre-commit-setup
Tom> hook.
Tom> Also skip the gnu-check-style hook, since it only checks patches, not files.
Tom> While we're at it, also bail out with unsupported if the pre-commit version is
Tom> too old, fixing PR testsuite/33945.
Seems fine to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2026-07-21 17:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 12:27 Tom de Vries
2026-07-21 17:43 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5lsutkz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox