From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ae0sO6kgcGrUQQEAWB0awg (envelope-from ) for ; Mon, 03 Aug 2026 01:01:29 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Meg2AduX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EE0AA1E09E; Mon, 03 Aug 2026 01:01:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4FF8C1E033 for ; Mon, 03 Aug 2026 01:01:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0D5FA4B99F60 for ; Mon, 3 Aug 2026 05:01:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0D5FA4B99F60 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Meg2AduX Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [IPv6:2607:f8b0:4864:20::a2b]) by sourceware.org (Postfix) with ESMTPS id 1B74F4B99F7E for ; Mon, 3 Aug 2026 05:01:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B74F4B99F7E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1B74F4B99F7E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a2b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785733262; cv=none; b=t4BL0LlXOpW8d/SAy/mx/JvbsGbEl4YzLzEkb0Nn63zcnncIeSnQm5lu76aEYGDl1TVetAOrXUyMQbGukzUjVvpWlGPJJmEKXQCjyg9JIeYzpj4sdXkcwF/NVZj70gRQxrCL7R5EYeREP7KZf7WII4JBlgver7l9A8/Si20i/e4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785733262; c=relaxed/simple; bh=HIJ900IRB7rGr5iA1PZLlcHzQsPkn7Tr8Kty+rd+7y8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KTnBs1wVBYo6twMmTXPG/RpxXzfM0SMIgWmLiX79XYfHUdFHhW0RYopL+e7CrRwO8Un7Ak96QbGK0A6GuxkyDpUPPVx9loCZIV+BJesmwyWMDvSVrIYC7+sjaOfstGEBX8loHoX7fiy0aAqG4gJmw0CAq3XRwALrNRKoo2SKbTY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Meg2AduX DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B74F4B99F7E Received: by mail-vk1-xa2b.google.com with SMTP id 71dfb90a1353d-5bfb3347dc4so1743799e0c.0 for ; Sun, 02 Aug 2026 22:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1785733261; x=1786338061; darn=sourceware.org; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=nKxfi+X2KG4KtjmThC7eYUspM7svX2dBhZ/RtJYewtI=; b=Meg2AduXsniLzrCQF/RKWAQSB+WEgeMdc+j6jjHhTNDzIx/J+ljWIjFYnUVg+pE6k9 N7LruIW6Zl2rrShjhdrKystd1a0nKj8IOPTQSOg6649Ava0gV4QXEVHttrkBUZvOPOQA GLCeCAm//YleSdag1UbkC2nTAIpuweMJbR7EFum0jSRCzdbYz2MK8IyeXqoNcUy2EEP+ RwlTOOuZzkhV88n4coPp/fCsAihGdnKonb/gh87Qe3a78F1aAvClrUbZWDfryqAsdKoB DaByTyDTOPNa/Z00zfZ36JgxbVqqXacjZ4B05v3e82Q1P/KN4gkfax0hmXrWyV0+77LB KxQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785733261; x=1786338061; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=nKxfi+X2KG4KtjmThC7eYUspM7svX2dBhZ/RtJYewtI=; b=ZEOokwDYfjPCzQrouVmj5Et+TnM1zgcvaHiHAM9ir/0k7lyJmGTlXvAk+8ZLq7N/ue Ho6zm+r6TxREOU4jUEDCSigQp7U/mWwTQqdNotQ0T2S2yTHOOt3FPpz9imar7/kqGnWs eu/B6wUj+rwfaOoM+cmVmUhAz6AmYB5Uq93mJovXoZS6UeDVxG9uUlTGEx4KiR1vKP09 dY/HWaVX5DpiNyB3rhMzf5YVXvJEEYz42MNJi7ai1xq/9J5W6oRDkSN6iMMQYPxprBc8 StuJN8qTCE0x3rt1ISgRf63BXl3ghvh3qBzB8hGVfGcU5F1PCu5HYX7AhMLM/9sZjzC4 fkKw== X-Gm-Message-State: AOJu0YxqX+tHP//vIgd97Pm/SD8xpcYExBQ5S8KcxlJ7v5INJjf7C5aJ NxOiIO/auWh6e9MR7stFydBvYykTIWcVGw4eM2Bj6J+SVBBtRuowL0wdDOtZvkkkxeo= X-Gm-Gg: AR+sD130vXBlBnL7NNsTWRkueayj/5dtC9wMcltRdWUlVEVkjJDleCscTnrqvlByF0v JUtwUUMWLCcYI4mwcKOYDRAucvW4Xd3EElofgusyScWPJvhoY86UWS2RPspLKorqVFW6OuHCglO 1EeiOs6GwuVRPABIP1ts6LBmK1u9Olr4FfMmhQHFjPrbm9kkov1BXGQMT5pAS67pyykW0/IHtET RX4L+Zyb1CD2V7IsJIZgDRfPIcG3NoI8fLSqVhCVuMwtJPCK7ORw5Cnz3pMUlpMw8b1bf4xzSR5 H7hKyLTHegJAenGwkORX3zUSekzhukQ7klnUmLE43cFjv/1G4u8Hi/FsYRv0cAcj9WF2PpB7n49 1RNlIUGKgB8+FDz9qOVEAMFq8z/YWGuRpsr+NMdGmzHT7R+iSL2pfkfiQqq0ZcIH6sjemOK13sk C27+JLcqc0MiRMMIgqqat46zHoCjw7B2Q40xmEmcd502rPbnHW8DcxHiFHABH41+gMZJTR0Kg= X-Received: by 2002:a05:6122:469e:b0:5bf:8469:c7a0 with SMTP id 71dfb90a1353d-5c387681548mr2821948e0c.3.1785733261480; Sun, 02 Aug 2026 22:01:01 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c37eb2fee3sm7182282e0c.7.2026.08.02.22.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 22:01:01 -0700 (PDT) From: Thiago Jung Bauermann To: Matthieu Longo Cc: , Luis Machado , Luis Machado , Simon Marchi , "Kevin Buettner" , Christina Schimpe , Christina Joos Subject: Re: [PATCH v1 4/6] gdb/linux-tdep: migrate linux_info_proc to file_reader_t In-Reply-To: <20260728151700.253720-5-matthieu.longo@arm.com> (Matthieu Longo's message of "Tue, 28 Jul 2026 16:16:58 +0100") References: <20260728151700.253720-1-matthieu.longo@arm.com> <20260728151700.253720-5-matthieu.longo@arm.com> User-Agent: mu4e 1.14.2; emacs 30.2 Date: Mon, 03 Aug 2026 05:00:58 +0000 Message-ID: <87h5lb3iid.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Matthieu Longo writes: > The patch migrates the code of linux_info_proc to use file_reader_t to > read the procfs files. > The availability of array_views allows to also simplify the logic in > several places, where null-terminating characters are replaced by spaces, > or where the file content is iterated line by line. > In the last case, a new helper function, extract_string_view_from_buffer, > encapsulates the logic for such iterations where string are separated by > tokens. > --- > gdb/linux-tdep.c | 135 +++++++++++++++++++++++++++++------------------ > 1 file changed, 84 insertions(+), 51 deletions(-) Thank you for addressing the review comments. Reviewed-by: Thiago Jung Bauermann -- Thiago (he/him)