Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Hannes Domani <ssbssa@yahoo.de>
Cc: Tom Tromey <tom@tromey.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] Windows gdb: Fix resetting of the debug-registers bit in ContextFlags
Date: Thu, 13 Aug 2026 11:04:28 -0600	[thread overview]
Message-ID: <87h5kyuf37.fsf@tromey.com> (raw)
In-Reply-To: <1087919146.2498548.1786565818407@mail.yahoo.com> (Hannes Domani's message of "Wed, 12 Aug 2026 20:16:58 +0000 (UTC)")

>>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:

Hannes>  Am Mittwoch, 12. August 2026 um 21:46:14 MESZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
>> >>>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:
>> >
>> >Hannes> So this creates a CONTEXT_DEBUG_REG_FLAG define with just the
>> >Hannes> debug-registers bit, and uses it in these problematic locations.
>> >
>> >Looks reasonable to me and I believe it addresses the comments in the
>> >previous review.
>> >Approved-By: Tom Tromey <tom@tromey.com>

Hannes> Thanks.
Hannes> I wonder if it would also be fine for gdb-18.

I think it's fine.  Thanks.

Tom

  reply	other threads:[~2026-08-13 17:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260722153353.429342-1-ssbssa.ref@yahoo.de>
2026-07-22 15:32 ` Hannes Domani
2026-08-06 16:36   ` Hannes Domani
2026-08-12 19:46   ` Tom Tromey
2026-08-12 20:16     ` Hannes Domani
2026-08-13 17:04       ` Tom Tromey [this message]
2026-08-14 11:30         ` Hannes Domani
2026-08-17  0:32   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h5kyuf37.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ssbssa@yahoo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox