From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ESCdKGQ4g2qfPy0AWB0awg (envelope-from ) for ; Mon, 17 Aug 2026 12:35:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=idS4qw1o; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A209D1E033; Mon, 17 Aug 2026 12:35:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 28D7C1E033 for ; Mon, 17 Aug 2026 12:35:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 592384BAE7C6 for ; Mon, 17 Aug 2026 16:35:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 592384BAE7C6 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=idS4qw1o Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 16F724BA9033 for ; Mon, 17 Aug 2026 16:35:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 16F724BA9033 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 16F724BA9033 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786984510; cv=none; b=Tm7yDGSCSEj/NBv9LGq4v3W1NwTpkMJ1P09y9W84CKNnAnXfo72n1Nht1pEgw2pbxSMTrV1KRKCxeFW9dntNgRdxwNDQbmRTibjI0NG/0VjHqVy/WnY3aVw2yjZDKotJ9u8jMstZ2IEp+y2DnZTFPhcnPZT68crq9J+GlgLVz50= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786984510; c=relaxed/simple; bh=/lh7QbiUv5+FmoNPGjhUU3x+N1KPUtrpMKza2791omM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=lr6mSAjZlo87C2MPtB2+4HV/LQ66q4M1RB5Jd88eL5kQtbRV5qV2yrIBCrfFUsTZVmgEhhXSAwyTNIrcAdbsmvXW5e8Z3ymJqFTtzCRlfDMTk3lvDwX+8nrAtzMa83dOd89Mmp4WOdmnhFqZhmAgNzDo6LyZ6bRF8d+jFGATOxQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=idS4qw1o DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 16F724BA9033 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786984509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AtrlrIurOc5MIb9TNsa3PLzFLk72ktecA9Os6Wrm0p0=; b=idS4qw1ok9K6tJ8NH3VBDZc6nfiws6wdfgLuM+rCA7RI1pR7drKqgS/n2vOuL/Tmd+XXb7 7uEESE9+560X6rCV/449N8fQDet2+IBdUHsLIUCZxTr996lOgKPqPntqTt8HNzO5CSPMdI ekPLkJeS2fY4NmMKl0efyAa7SFjsJvs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-ncfHDS5gNe-vx60qe-rrlg-1; Mon, 17 Aug 2026 12:35:08 -0400 X-MC-Unique: ncfHDS5gNe-vx60qe-rrlg-1 X-Mimecast-MFC-AGG-ID: ncfHDS5gNe-vx60qe-rrlg_1786984507 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-490a767c7dcso30670595e9.2 for ; Mon, 17 Aug 2026 09:35:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786984507; x=1787589307; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=AtrlrIurOc5MIb9TNsa3PLzFLk72ktecA9Os6Wrm0p0=; b=nXXcpCRo2igKKMxZT55+nX7eMTKAgiwZvR25WsP9+S4GX2tFGL9HSpCb9TphTXCg2I BfkUoVPryMRA/KgKLVrDkf2n1LkI6yOqaS9ABT6awN+FzmiUPkIIljG8wQcBt46MhMU9 fYdQkOfEK6JGtZuhsECmFl2Ns9VFyvp1Bg5paxTvG7nhkvEZWRZdlO7YuaLDAOBowZCc +pF8NhqxlyE1Inl+bFFgdiHN6VwCSwb0xxYMOrMjwISdM2go9kZFV1BKDSJDp/SQ3sEV 8m+8Lcmmg+hJb08A8ArM619De0C1m+4ySOEuodD21s4ENjD+Ys9qmLc7uuYbU9qywxO8 Tiqw== X-Forwarded-Encrypted: i=1; AHgh+RoTylOxpvgsHd4JroencgKuf41gdvHcPEyjSlm63xOXv0SOyfNvUHoNh6jGILitn+MGDile1fLWwW7obg==@sourceware.org X-Gm-Message-State: AOJu0Yx0iEVXCIiu83sEyuZ3XSewNTdBYpVmmueZSN47uWI0nOATyryW RSD2DOlI4kOCPoCvuYrAHGLptlzzq6BTLf6eH2QxHAZl7Lsec9q7gzsY3nstIkr+7SUirEiCW+W V1DniESmxo0zojeRa0DDRGzYmK9udisnbKSRig4cFqzc6aSxNmOi0rRubrLZ7mmw= X-Gm-Gg: AR+sD12Fk2VaiwZPtS7LAN8di8itVHNoeKqEs9PYdQRY4ZopNrWV66HID/v5Hg1Q6Qc 1FBXtJlXdJbN1gEm5nLIAAzk9uR7whzn9CJ3Wcci41GOS4x+W516zLS62AhxFxIjtpnp/IH3O6i nz/ZdL2ppSQa8oiV+FgIajZypwGf9tBfDTgiDbKa7QJwjSDWaDr83TE66vBQ6stM7iU/JSd+gD3 J7FATfRaH693GOXnCNNPtGrqxcCfYbpsrGLKxWI61NskPZ5RYiw23ztw6JcbtCsU36hG5QNSgrM GWoy26DFk52StlgGB6icPabthqNe3GMy467d9fO1IU0SDqQN/flYtLv2cidQ++qOLqPMI2hQRsY Btngh9VbcoViIGN2YOmw= X-Received: by 2002:a05:600c:4295:b0:495:5e3d:15e1 with SMTP id 5b1f17b1804b1-4998799e0f0mr245682265e9.16.1786984507193; Mon, 17 Aug 2026 09:35:07 -0700 (PDT) X-Received: by 2002:a05:600c:4295:b0:495:5e3d:15e1 with SMTP id 5b1f17b1804b1-4998799e0f0mr245681715e9.16.1786984506786; Mon, 17 Aug 2026 09:35:06 -0700 (PDT) Received: from localhost (67.72.115.87.dyn.plus.net. [87.115.72.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996100082sm217048335e9.2.2026.08.17.09.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 09:35:06 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 08/13] gdb/dwarf2: remove uses of sprintf In-Reply-To: <20260817151646.152571-9-simon.marchi@efficios.com> References: <20260817151646.152571-1-simon.marchi@efficios.com> <20260817151646.152571-9-simon.marchi@efficios.com> Date: Mon, 17 Aug 2026 17:35:05 +0100 Message-ID: <87h5ks3dty.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yZ66-cUoSnSN0Ehiu82cwsZUQCunJnM1BDiT-QKqXms_1786984507 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > When building on macOS, I get some: > > /Users/smarchi/src/binutils-gdb/gdb/dwarf2/read.c:3773:4: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations] > 3773 | sprintf (buf, "TU %s at offset %s", hex_string (sig_type->signature), > | ^ > > Replace them with xsnprintf, which takes the destination size and asserts > that the output was not truncated. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: Ie0324f75e5d4aad9b647007848459bf4af5998a6 > --- > gdb/dwarf2/read.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c > index ca475f53745d..a8b99425554a 100644 > --- a/gdb/dwarf2/read.c > +++ b/gdb/dwarf2/read.c > @@ -3770,15 +3770,16 @@ process_queue (dwarf2_per_objfile *per_objfile) > if (signatured_type *sig_type = per_cu->as_signatured_type (); > sig_type != nullptr) > { > - sprintf (buf, "TU %s at offset %s", hex_string (sig_type->signature), > - sect_offset_str (per_cu->sect_off ())); > + xsnprintf (buf, sizeof (buf), "TU %s at offset %s", > + hex_string (sig_type->signature), > + sect_offset_str (per_cu->sect_off ())); > /* There can be 100s of TUs. Only print them in verbose mode. */ > debug_print_threshold = 2; > } > else > { > - sprintf (buf, "CU at offset %s", > - sect_offset_str (per_cu->sect_off ())); > + xsnprintf (buf, sizeof (buf), "CU at offset %s", > + sect_offset_str (per_cu->sect_off ())); > debug_print_threshold = 1; > } > > -- > 2.55.0