From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iR6UKYltiGq/+TMAWB0awg (envelope-from ) for ; Fri, 21 Aug 2026 11:23:53 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dyOEFYcl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A5E691E0A3; Fri, 21 Aug 2026 11:23:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3BF9F1E033 for ; Fri, 21 Aug 2026 11:23:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13A564BAE7C8 for ; Fri, 21 Aug 2026 15:23:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 13A564BAE7C8 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dyOEFYcl Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 623F64BA900D for ; Fri, 21 Aug 2026 15:23:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 623F64BA900D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 623F64BA900D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787325807; cv=none; b=lmG6EU3kjGgmLYj4zLbhD2V34IgWWGPAnBQxbU09bc3rYZn5eoETJ2T5WKBq502RnaF7MVEDo4BLR6GiDQbvQ+TyEKeH4eBXzWE9Seh9heWS/qgJcFE2rsAuEZUozEllJ5wiYyNxV8dELTUETZ4ilKjUT/wDg6cPrv3xlKaMuug= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787325807; c=relaxed/simple; bh=7eRIEGTkUSDxpc3C2srYoggwa3V6nrx7vUrZE+IBJJQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KnHN+U9IuKrNtPF/y07DYNg2e3tylUOfE1hbP06ey1kjqeiUxAImRaD0NBD7UljVTVr2SOGZgEguWtUob3A0W2vIwgZiZDgnejJjsdekVL42L0SkRmpDlwcqdTgys7+VJEgeRgZ2Gh9/5RJX2M4eld2oUx8dBwQ3FCM/rjUnvcY= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dyOEFYcl reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 623F64BA900D Received: from eig-obgw-6003b.ext.cloudfilter.net ([10.0.30.175]) by cmsmtp with ESMTPS id xPDawJhYRusRSxR5awGu9B; Fri, 21 Aug 2026 15:23:26 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xR5ZwrsarqLljxR5awrC0t; Fri, 21 Aug 2026 15:23:26 +0000 X-Authority-Analysis: v=2.4 cv=ZLHXmW7b c=1 sm=1 tr=0 ts=6a886d6e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=9bpZ89Y2-DEMVcHubycA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ExPSiUsP8zeNCJbfELiM6BaFP0ZWDfnivkOfEKbC0RI=; b=dyOEFYclJpOKeL3IHCdpZS3mgs r4tZebwt+mY8vX/k9WHA/KiYLeZzPxKZIh9w69X2Erk1Fz2neghVx3K5YjRqdU4Qi8ntP4VOc0mGK RqUZqRofgrdH/U3xfo4NU8wFc; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:42344 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wxR5Z-00000004CLA-269L; Fri, 21 Aug 2026 09:23:25 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: pass type name directly to arch_composite_type In-Reply-To: <20260813161905.345483-2-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 13 Aug 2026 12:18:59 -0400") References: <20260813161905.345483-1-simon.marchi@efficios.com> <20260813161905.345483-2-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 21 Aug 2026 09:23:23 -0600 Message-ID: <87h5knsdjo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1wxR5Z-00000004CLA-269L X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:42344 X-Source-Auth: tom+tromey.com X-Email-Count: 16 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOIMmKvxgy0K44ezVUB9xoOAvFk1HrrjoyF5J78Xa5fJMyEcGXAmaeawxaOkWZgHieIbAY7fEhP9pzuN7/vLyLcTXzVfB1QSMEsPILRR7pIdqbkw4ymK oIIr6C3jTEIe+YmX66tnfYXVAIjzl6toM56NT9VXcWuPqRC0swLGNY9v+UQyP2Or+wdcp6eycWlb76o+VFSs+pmMi05/dFLtk64= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> First, it's not necessary to duplicate the string, we can pass the Simon> literal string directly, and its lifetime will be appropriate. Second, Simon> we can pass the name directly to arch_composite_type, instead of doing a Simon> separate set_name call. So, replace the above with: Simon> sigval_type = arch_composite_type (gdbarch, "sigval", TYPE_CODE_UNION); Thanks. One tiny nit below. Simon> /* sival_t */ Simon> - type *sigval_union_type = arch_composite_type (gdbarch, nullptr, Simon> + type *sigval_union_type = arch_composite_type (gdbarch, "sigval_t", Simon> TYPE_CODE_UNION); The comment says "sival_t" but the type says "sigval_t". The Linux headers say the latter, so the comment is wrong. Personally I think this comment isn't so useful and could be removed, but fixing it would also be fine. Approved-By: Tom Tromey Tom