From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kUyGG9IVj2oNdwMAWB0awg (envelope-from ) for ; Wed, 26 Aug 2026 12:35:30 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XUEuMoFN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 533321E033; Wed, 26 Aug 2026 12:35:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7502F1E033 for ; Wed, 26 Aug 2026 12:35:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9A7104B9DB49 for ; Wed, 26 Aug 2026 16:35:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A7104B9DB49 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XUEuMoFN Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 7611A4BA2E1D for ; Wed, 26 Aug 2026 16:35:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7611A4BA2E1D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7611A4BA2E1D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787762104; cv=none; b=fVNGz6jj936kGxMIK1fvV3JOQ6WPALjcfT6eHxqG27NPiKAyzf5Qggl5gJ3r95KBseanPNXBqixLBQ/5c4kfCew3HDOmRZttkWDvBPD3SAGfUt2yZdBhsE5BhlfhKbXi+qyw1dO9O8t+pueaEmvWnDXy5VqrwHOBSl0KceMiHYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787762104; c=relaxed/simple; bh=oXvd3pcufvQysTRGQgCqI2iq1wYNNJTuKDSsdMAL2E8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=N8aNg4hgVTmdoICNOIaqTg/z1NbIpHyLXj5eyRK/58u5ir0IAtZPtmILx++dLPnHDo+hQxf7K6cRiwx5O43H9X2bGarwPjrHLw8seakUZNRbBeM9clQ/cTRZElAMKBgo3ttT/AG/TCMuptBEbaoGsKmMWMxgCfQsq0ljM1G5S+M= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XUEuMoFN DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7611A4BA2E1D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787762103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kzn9AwvKfgADUWK9ovRz928G6OTSreUdMdoF626wuB8=; b=XUEuMoFNn1HrKrz9PXhyOjYkUJJHAMQXSRvScFbUwZNsrlTYJcpLkNT+C73k/snyBan/FZ 98InPOl/v9KDXcMmxfxpzh6A6d98ODMyQEIZmpQZZy2Yff2vA5PIOrOKDA5me7M1vcavII C9zOowf7wloBk7QTXKG0GkpdKTzJm7E= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-dqWdPomHNxe_PYRlDMWoTQ-1; Wed, 26 Aug 2026 12:35:02 -0400 X-MC-Unique: dqWdPomHNxe_PYRlDMWoTQ-1 X-Mimecast-MFC-AGG-ID: dqWdPomHNxe_PYRlDMWoTQ_1787762101 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-c25148e933eso88146066b.0 for ; Wed, 26 Aug 2026 09:35:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787762101; x=1788366901; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Kzn9AwvKfgADUWK9ovRz928G6OTSreUdMdoF626wuB8=; b=os809wC/h9rE2FsueoDyfJewR0pcbSuli8XVnh1Zxu5+Es49xzHr/m5rMsIIl+f63O 5d4+qgIQu0/OciXhQuhP0MClS8uhFWuTzgqV8edVlOPb5zTxOOemR3CJpwtMgKkJN6LU 2r+dKFbCN2rmwVvuse89a78S7KyzSA8QgOKWky5umPdDK52jx/C2nB8jykRbewfRFWIt loijG+d1V+Bkm8ZWyCY2xh/GV1SIRcYbbu+fTfw0zgf2TN+QnyUp4AxT4J1WJPHbOOq1 yJYHFbPIM4l0JW193j/rIsQyDAISSHUhmrcZjyR87TQ+qm5bMaQfNsPrdAD0OwpajnYM Bq2g== X-Forwarded-Encrypted: i=1; AHgh+RqoZyc0d46fIq0IFkK0MtRdee9tFtKCjaKpSIeLdlCDIkD9QGwrZ9uYfjNHH4hdKjuwgT3pzlmhnFBlkw==@sourceware.org X-Gm-Message-State: AFuF++mJjtZrG1m3Sf5xIEsaYVIAQELz95R2besNmFN7azuqPwp7QzX5 PgYr/G3vRDbJMc1alQ+DktIWdrTwOfnOvZE/XlI3hgh5zOdSxw4S9spkXByWntxU66ndkvDbzGh NADmW3ARJIqzPtdDeqpUp3eGF7040rGs2Zoi20prNRVmSznnX0QPXzlh8YRCVMLM+r+NjfL0= X-Gm-Gg: AR+sD13s5n4IwcLyzS2VvjLJmqjmxmHfC18etNA7NcrdabwROssvL9px/0yDhGAcBUI X+ZwWN64MElqL3PKV4K+u+eqLAMFAehwOD+rp4gRjL4U0lBJRSJYVWOCaajByCNDjHoft35SkcD YrWAo50w8tSj4NdJcBJdqt3KfErodnqlnJmMMWPCCOH1GG5PKaxU8w/rjste+1EcF14KjIa3viE 6YOVJgle5ChssSiqyfjyS8ybYvFWOZSfoIJxCUP8WRyG2MskQnRtaoyeE6bMb4iGvbunZYH9cT0 FPcO1vOThtdpTqAm+Acrb06GIvdj9lok1iRbm26ZhyCL6HvYGVmOe0DKhzXKrpKjIEj2FaYR31m aCGHWRnp3M8K1qomTR5HaxdThPsA= X-Received: by 2002:a17:907:6d27:b0:c20:3679:a2e6 with SMTP id a640c23a62f3a-c250bbda55cmr962708466b.10.1787762100584; Wed, 26 Aug 2026 09:35:00 -0700 (PDT) X-Received: by 2002:a17:907:6d27:b0:c20:3679:a2e6 with SMTP id a640c23a62f3a-c250bbda55cmr962700366b.10.1787762100067; Wed, 26 Aug 2026 09:35:00 -0700 (PDT) Received: from localhost (128.223.159.143.dyn.plus.net. [143.159.223.128]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c250a7303casm769886066b.25.2026.08.26.09.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 09:34:59 -0700 (PDT) From: Andrew Burgess To: Nikita.Venkatesh@arm.com, gdb-patches@sourceware.org Cc: nd@arm.com, Nikita Venkatesh Subject: Re: [PATCH] Include in ui-style.h In-Reply-To: <20260826153256.907020-1-Nikita.Venkatesh@arm.com> References: <20260826153256.907020-1-Nikita.Venkatesh@arm.com> Date: Wed, 26 Aug 2026 17:34:58 +0100 Message-ID: <87h5kgu9fx.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wB9bhxp4x9HmHGx28thNyJTAr2H25Utoltq1_S9J3NY_1787762101 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Nikita.Venkatesh@arm.com writes: > From: Nikita Venkatesh > > ui-style.h uses std::array without including directly. > > This builds successfully with GCC 8 and libstdc++ as its header > includes . However, libc++'s does not include with > Apple Clang 13.0.0. This causes the GDB builds to fail on macOS with: > > error: implicit instantiation of undefined template > 'std::array' > > Include directly in ui-style.h rather than relying on the > include from . > > OK for trunk and gdb-18 branch? LGTM. Approved-By: Andrew Burgess thanks, Andrew > --- > gdb/ui-style.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gdb/ui-style.h b/gdb/ui-style.h > index fc40b93709d..201a6f302d9 100644 > --- a/gdb/ui-style.h > +++ b/gdb/ui-style.h > @@ -19,6 +19,8 @@ > #ifndef GDB_UI_STYLE_H > #define GDB_UI_STYLE_H > > +#include > + > /* One of the color spaces that usually supported by terminals. */ > enum class color_space > { > -- > 2.34.1