Re: [PATCH] Return lazy value from allocate_repeat_value

[Tom Tromey <tromey@adacore.com>]

>> +    # A regression test for a buffer overflow.  PR gdb/34132.
>> +    gdb_test_no_output {set $ctable = (char *) ctable2}

Simon> Just wondering, is the use of the convenience var necessary?

Doesn't seem to be, that was just a leftover from my various attempts to
reproduce the crash.

>> +    gdb_test_no_output "set max-value-size 16"
>> +    gdb_test_no_output "set print elements 10"
>> +    gdb_test {print $ctable[0] @ 20} \
>> +	[quotemeta {$@DECIMAL = {97 'a', 88 'X' <repeats 15 times>...}}]
>> +    gdb_test_no_output "set max-value-size 65536"
>> +    gdb_test_no_output "set print elements 200"

Simon> Can you do
Simon>   with max-value-size 16 -- with print elements 10 -- ...
Simon> to avoid having to set and reset the settings?

Yep.

Simon> Approved-By: Simon Marchi <simon.marchi@efficios.com>

Thanks.

Tom