From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10319 invoked by alias); 15 Mar 2012 14:27:44 -0000 Received: (qmail 10301 invoked by uid 22791); 15 Mar 2012 14:27:42 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Mar 2012 14:27:27 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2FER24U004195 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 15 Mar 2012 10:27:02 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2FER0dG002772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 15 Mar 2012 10:27:01 -0400 From: Tom Tromey To: Joel Brobecker Cc: Roland Schwingel , gdb-patches@sourceware.org Subject: Re: [PATCH] Add dll trampoline code handling for windows 64bit References: <4F610188.5010001@onevision.com> <20120314210310.GJ2853@adacore.com> Date: Thu, 15 Mar 2012 14:27:00 -0000 In-Reply-To: <20120314210310.GJ2853@adacore.com> (Joel Brobecker's message of "Wed, 14 Mar 2012 14:03:10 -0700") Message-ID: <87fwdac53f.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00537.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> That is very odd, the script should indeed indent the sources Joel> in a way that follows the GNU Coding Standards. Perhaps we are Joel> missing some parameters in the call to that script that override Joel> certain defaults that may no longer match our standards. When I looked at this for GCC, some years ago now, GNU indent did not have all the needed options to really mimic GNU style as actually used. I would like it if we could use some indentation tool. This would remove a lot of drudgery from patch review. But, this would require someone doing an investigation into the existing tools to see if they can do the job. Maybe GNU indent is better now (though I never heard a response to my various bug reports); or maybe uncrustify (http://uncrustify.sourceforge.net/) is good enough. Right now, unless someone volunteers to do the above, I think we should remove gdb_indent.sh as being actively confusing. Here's a starting point for uncrustify: http://debbugs.gnu.org/db/63/6318.html This bug has a GNU-ish config file attached. Tom