From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10599 invoked by alias); 11 Sep 2012 20:21:15 -0000 Received: (qmail 10590 invoked by uid 22791); 11 Sep 2012 20:21:14 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Sep 2012 20:20:49 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8BKKlLu021998 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 11 Sep 2012 16:20:47 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8BKKeOa027390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 11 Sep 2012 16:20:46 -0400 From: Tom Tromey To: markus.t.metzger@intel.com Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com, jan.kratochvil@redhat.com, palves@redhat.com, kettenis@gnu.org Subject: Re: [patch v3 04/16] source, disasm: optionally prefix source lines with filename References: <1344949171-9545-1-git-send-email-markus.t.metzger@intel.com> <1344949171-9545-5-git-send-email-markus.t.metzger@intel.com> Date: Tue, 11 Sep 2012 20:21:00 -0000 In-Reply-To: <1344949171-9545-5-git-send-email-markus.t.metzger@intel.com> (markus t. metzger's message of "Tue, 14 Aug 2012 14:59:19 +0200") Message-ID: <87fw6o8g6f.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00179.txt.bz2 >>>>> "Markus" == markus t metzger writes: Markus> * source.c (print_source_lines_base): Prefix source line with filename if This line looks over-long. Markus> + print_source_lines (symtab, next_line, mle[i].line + 1, psl_flags); A few of these lines look too long as well, they should be split. Otherwise this seems ok. Tom