From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94837-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30102 invoked by alias); 25 Sep 2012 20:28:06 -0000
Received: (qmail 30091 invoked by uid 22791); 25 Sep 2012 20:28:04 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Sep 2012 20:27:46 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8PKRjjY016554	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 25 Sep 2012 16:27:46 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8PKRig0008286	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 25 Sep 2012 16:27:45 -0400
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Siddhesh Poyarekar <siddhesh@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Eliminate local variables to use TYPE_LENGTH directly
References: <20120924173542.625d322c@spoyarek>	<20120925082558.GA9305@host2.jankratochvil.net>
Date: Tue, 25 Sep 2012 20:28:00 -0000
In-Reply-To: <20120925082558.GA9305@host2.jankratochvil.net> (Jan Kratochvil's	message of "Tue, 25 Sep 2012 10:25:58 +0200")
Message-ID: <87fw6526gv.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00560.txt.bz2

Jan> While correct I find this expression too tricky, check_typedef should be
Jan> called rather ahead of some block of code later depending on it.

I often think we should have TYPE_LENGTH call check_typedef invisibly.
The current situation seems error-prone.

Tom