From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97995-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29466 invoked by alias); 25 Jan 2013 14:28:55 -0000
Received: (qmail 29453 invoked by uid 22791); 25 Jan 2013 14:28:53 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Jan 2013 14:28:18 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0PESH86020955	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 25 Jan 2013 09:28:17 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r0PESGYh010835	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 25 Jan 2013 09:28:16 -0500
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename
References: <20130117222242.GG16249@host2.jankratochvil.net>	<87ip6q1gbo.fsf@fleche.redhat.com>	<20130124215609.GA31688@host2.jankratochvil.net>
Date: Fri, 25 Jan 2013 14:28:00 -0000
In-Reply-To: <20130124215609.GA31688@host2.jankratochvil.net> (Jan	Kratochvil's message of "Thu, 24 Jan 2013 22:56:09 +0100")
Message-ID: <87fw1pl4lb.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00625.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Tom> This spot still uses symtab->filename directly.
Tom> Is that intentional?  If so I think it should perhaps have a comment.

Jan> Yes.
Jan> +         /* Check first sole SYMTAB->FILENAME.  It does not need to be
Jan> +            a substring of symtab_to_fullname as it may contain "./" etc.  */

Sorry, missed that.

Tom> This spot uses filename_cmp with symtab_to_filename.
Tom> Is that intentional?
Tom> It seems a bit strange to me to allow the filename-display setting to
Tom> control comparisons.

Jan> Because this is a maintenance command.

Ok, I see.  I'm satisfied.

Tom