From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32212 invoked by alias); 1 Feb 2013 21:53:03 -0000 Received: (qmail 32203 invoked by uid 22791); 1 Feb 2013 21:53:03 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Feb 2013 21:52:56 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r11LqKUJ024906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 1 Feb 2013 16:52:56 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r11JLC2X005656 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 1 Feb 2013 14:21:13 -0500 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix assert crashes with minidebuginfo References: <20130201182134.GA14273@host2.jankratochvil.net> Date: Fri, 01 Feb 2013 21:53:00 -0000 In-Reply-To: <20130201182134.GA14273@host2.jankratochvil.net> (Jan Kratochvil's message of "Fri, 1 Feb 2013 19:21:34 +0100") Message-ID: <87fw1f4z87.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00039.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> 2013-02-01 Jan Kratochvil Jan> * elfread.c (elf_symfile_read): Limit separate debug info additions to Jan> files with no separate debug info. Jan> * objfiles.c (add_separate_debug_objfile): Add gdb_assert calls. Jan> * symfile.c (read_symbols): Call find_separate_debug_file_in_section Jan> only for files with no separate debug info. Ok, I understand now. I think this patch is fine. Please put it in. Tom