From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32566 invoked by alias); 10 Apr 2013 22:35:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32516 invoked by uid 89); 10 Apr 2013 22:35:31 -0000 X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 10 Apr 2013 22:35:30 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UQ3bz-0004Oj-Mr from Thomas_Schwinge@mentor.com ; Wed, 10 Apr 2013 15:35:27 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 10 Apr 2013 15:35:27 -0700 Received: from tftp-cs (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Wed, 10 Apr 2013 15:35:26 -0700 Received: by tftp-cs (Postfix, from userid 49978) id C03E9C5320; Wed, 10 Apr 2013 15:35:26 -0700 (PDT) From: Thomas Schwinge To: Joel Brobecker CC: , Subject: Re: [PATCH,HURD] Fix reading core In-Reply-To: <20130409234117.GC24389@adacore.com> References: <20130211020109.GK5926@type.youpi.perso.aquilenet.fr> <20130409234117.GC24389@adacore.com> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/23.4.1 (i486-pc-linux-gnu) Date: Thu, 11 Apr 2013 02:44:00 -0000 Message-ID: <87fvyyggkc.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Virus-Found: No X-SW-Source: 2013-04/txt/msg00291.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1060 Hi! On Tue, 9 Apr 2013 16:41:17 -0700, Joel Brobecker w= rote: > > The i386 GNU/Hurd ELF core format actually follows the uaccess gregset_t > > array format, not the Mach thread state format. This fixes gdb reading > > it. > >=20 > > * gdb/i386gnu-nat.c (CREG_OFFSET): New macro. > > (creg_offset): New array. > > (CREG_ADDR): Use creg_offset instead of reg_offset. >=20 > Did anyone review this? I don't know GNU/Hurd, but the patch looks > very plausible. Not yet, but it's on my list... (together with other Hurd GDB work). Anyway, Joel, thanks for following up on Samuel's patch, and not letting it fall through the cracks! > Do you have write access to the GDB repository? If not, do you have > copyright assignment papers on file? This patch is small enough that > we can take it as a tiny patch, but if you think you're going to > send more patches, we should probably get you started on those. I'd support all that; Samuel's not on file for GDB (but is for other packages, such as Hurd proper). Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 489 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAEBAgAGBQJRZekjAAoJEGe3hdm9kOiitJoH/Rx03D/dwekQLwtcF02S/FiS t2I11isOvhaC4ayVqHjrgEoKb4jUJ0WYCgx9YjPYMgAfJehJFqLyzT81R3LAa7XY WD18J+x47Mrpy/Bk0kEyQc/OTmumwHoB04nHAAg0iueLrRLrb37M/I2SDmRA0yjP VhorhUk4yvbuZMT8HQjdxj+8f412wgSt504jfB51nCjWkeQJy6WwrN9zd33S5jCD SVN8CCDsOHSJ2eEsGvfLU8TGmytJfJeNEG8yY13z4spTeQ/KOmnhrB5DkXXzsQ5R GmR5gbPJc9NYZTdZrFdJglPy9UQIDiYtpwY7Vo0o+1Aa/rleL9vzqjuw6BSiicU= =YnwH -----END PGP SIGNATURE----- --=-=-=--