From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21212 invoked by alias); 4 Jun 2014 20:22:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21201 invoked by uid 89); 4 Jun 2014 20:22:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jun 2014 20:22:04 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s54KM1J7030650 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Jun 2014 16:22:01 -0400 Received: from barimba ([10.3.113.4]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s54KM0P4004483 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 4 Jun 2014 16:22:00 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 03/12] Iterate over 'struct varobj_item' instead of PyObject References: <1392367471-13527-1-git-send-email-yao@codesourcery.com> <1392367471-13527-4-git-send-email-yao@codesourcery.com> <87oayrj9j6.fsf@fleche.redhat.com> <537EA4D2.2060302@codesourcery.com> Date: Wed, 04 Jun 2014 20:22:00 -0000 In-Reply-To: <537EA4D2.2060302@codesourcery.com> (Yao Qi's message of "Fri, 23 May 2014 09:30:58 +0800") Message-ID: <87fvjka0if.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-06/txt/msg00216.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2014-05-22 Pedro Alves Yao> Yao Qi Yao> * python/py-varobj.c (py_varobj_iter_next): Return NULL if Yao> gdb_python_initialized is false. Move some code from varobj.c. Yao> * varobj-iter.h (struct varobj_item): Moved from varobj.c. Yao> * varobj.c: Move "varobj-iter.h" inclusion earlier. Yao> (struct varobj_item): Moved to varobj-iter.h". Yao> (varobj_clear_saved_item): New function. Yao> (update_dynamic_varobj_children): Move python-related code to Yao> py-varobj.c. Yao> (free_variable): Call varobj_clear_saved_item and Yao> varobj_iter_delete. Thanks, this is ok. Tom