From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23784 invoked by alias); 5 Jun 2014 20:47:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23728 invoked by uid 89); 5 Jun 2014 20:47:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jun 2014 20:47:38 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s55Kla0i008587 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Jun 2014 16:47:36 -0400 Received: from barimba ([10.3.113.4]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s55KlZRc002239 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 5 Jun 2014 16:47:35 -0400 From: Tom Tromey To: Keven Boell Cc: gdb-patches@sourceware.org, sanimir.agovic@intel.com Subject: Re: [PATCH 01/23] dwarf: add dwarf3 DW_OP_push_object_address opcode References: <1401861266-6240-1-git-send-email-keven.boell@intel.com> <1401861266-6240-2-git-send-email-keven.boell@intel.com> Date: Thu, 05 Jun 2014 20:47:00 -0000 In-Reply-To: <1401861266-6240-2-git-send-email-keven.boell@intel.com> (Keven Boell's message of "Wed, 4 Jun 2014 07:54:04 +0200") Message-ID: <87fvjj5biw.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-06/txt/msg00285.txt.bz2 >>>>> "Keven" == Keven Boell writes: Keven> The opcode pushes the address of the object being evaluated. The Keven> semantic is equivalent to the implicit push of the base address Keven> of a data member location. This looks good. However, normally if one updates the DWARF expression evaluator, one should either try to update the DWARF->AX translator in dwarf2loc.c, or provide some rationale explaining why it either can't be done or is otherwise undesirable. In this case I think the translation seems doable. See dwarf2_compile_expr_to_ax. There's also dwarf2read.c:decode_locdesc, but it is hackier and more likely to be ignorable. Tom