From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7218 invoked by alias); 5 Nov 2014 01:54:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6022 invoked by uid 89); 5 Nov 2014 01:54:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Nov 2014 01:54:38 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1Xlpnu-00052E-82 from Yao_Qi@mentor.com ; Tue, 04 Nov 2014 17:54:34 -0800 Received: from GreenOnly (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.181.6; Tue, 4 Nov 2014 17:54:33 -0800 From: Yao Qi To: Doug Evans CC: Subject: Re: [PATCH 2/6] DW attribute macro MACRO_AT_func and MACRO_AT_range References: <1414195968-3333-1-git-send-email-yao@codesourcery.com> <1414195968-3333-3-git-send-email-yao@codesourcery.com> <21593.22575.941029.980760@ruffy2.mtv.corp.google.com> Date: Wed, 05 Nov 2014 01:54:00 -0000 In-Reply-To: <21593.22575.941029.980760@ruffy2.mtv.corp.google.com> (Doug Evans's message of "Tue, 4 Nov 2014 14:50:23 -0800") Message-ID: <87fvdypgap.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00092.txt.bz2 Doug Evans writes: Doug, Thanks for reviewing these patches. > IWBN if one could add new macros simply by writing a new function. > > Can _handle_macro_attribute be rewritten such that > MACRO_AT_{func,range} are themselves functions? I don't see any difficulties to implement MACRO_AT_{func,range} as functions here, but could you tell me why do you prefer to do that? Is it because they are macros? After all, in dwarf assembler, all attributes are handled in a single function, rather than the way that each attribute is handled in the separate function. MACRO_AT_{func,range}, as special attributes from the users' point of view, should be handled in a way consistent with other attributes, IMO. --=20 Yao (=E9=BD=90=E5=B0=A7)