From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29498 invoked by alias); 14 Nov 2014 13:02:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29481 invoked by uid 89); 14 Nov 2014 13:02:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Nov 2014 13:02:03 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1XpGVj-0007Fh-1z from Yao_Qi@mentor.com ; Fri, 14 Nov 2014 05:01:59 -0800 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.181.6; Fri, 14 Nov 2014 05:01:58 -0800 From: Yao Qi To: Pedro Alves CC: , , Joel Brobecker Subject: Re: gnulib's errno module was imported References: <87oasaibe6.fsf@codesourcery.com> <5465EBAD.3070108@redhat.com> Date: Fri, 14 Nov 2014 13:02:00 -0000 In-Reply-To: <5465EBAD.3070108@redhat.com> (Pedro Alves's message of "Fri, 14 Nov 2014 11:46:53 +0000") Message-ID: <87fvdmhr5o.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00301.txt.bz2 Pedro Alves writes: > I think this will keep haunting and blocking us until we fix it. > Let us try again to fix it. > Can we reevaluate this? Sure. > So that leaves handling the case of gnulib making up a EILSEQ value, > which we take as meaning the system really doesn't really define it, > which will be the systems GNU iconv returns ENOENT instead. > > With that rationale, how about we try something like this? I am fine with your approach, but I am wondering why don't we simply check ENOENT in the places where we check EILSEQ? @@ -513,6 +513,7 @@ convert_between_encodings (const char *from, const char= *to, switch (errno) { case EILSEQ: + case ENOENT: { int i; =20 @@ -651,6 +652,7 @@ wchar_iterate (struct wchar_iterator *iter, switch (errno) { case EILSEQ: + case ENOENT: /* Invalid input sequence. We still might have converted a character; if so, return it. */ if (out_avail < out_request * sizeof (gdb_wchar_t)) This looks cleaner to me (some comments should be added, of course). --=20 Yao (=E9=BD=90=E5=B0=A7)