From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8658 invoked by alias); 17 Feb 2015 11:56:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8645 invoked by uid 89); 17 Feb 2015 11:56:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL,BAYES_20,LIKELY_SPAM_BODY,SPF_PASS,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 17 Feb 2015 11:56:46 +0000 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t1HBufVf007080 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 17 Feb 2015 11:56:41 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t1HBueS4016333 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 17 Feb 2015 11:56:40 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t1HBueBS016326; Tue, 17 Feb 2015 11:56:40 GMT Received: from termi.oracle.com (/10.175.193.114) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 17 Feb 2015 03:56:39 -0800 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH V4 0/9] Add support for DTrace USDT probes to gdb References: <1422874968-382-1-git-send-email-jose.marchesi@oracle.com> <877fvh710o.fsf@redhat.com> Date: Tue, 17 Feb 2015 11:56:00 -0000 In-Reply-To: <877fvh710o.fsf@redhat.com> (Sergio Durigan Junior's message of "Mon, 16 Feb 2015 20:57:43 -0500") Message-ID: <87fva4g309.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00433.txt.bz2 > [Changes from V3: > - Added some missing spaces after periods in the documentation patch. > Spotted by Eli. > - Sort ChangeLog entries so they reflect the changes in the same order > than the diffs. > - Use transformed tool names in the pdtrace script, which is now > processed through configure. Introduce a new GDB_AC_TRANSFORM macro > to avoid repeating a code idiom and use it to define both > GDB_TRANSFORM_NAME and GCORE_TRANSFORM_NAME in the main > configure.ac. > - Copyright year updated to 2015 in new files introduces by the patch > series.] Thanks for the series, Jose! The patches look pretty good. I approved almost all of them. The only exception is the testcase patch, but not because of the testcase per se: rather, it is because the new transform.m4 file that you added. I think we're 99% done on this. Let's just wait to see what Pedro thinks about the transform thing (since he was the one who requested it before). Thanks. I will remove the GDB_AC_TRANSFORM M4 macro from [PATCH V4 7/9] and make it use verbose idioms in gdb/testsuite/configure.ac: STRIP_TRANSFORM_NAME=`echo strip | sed -e "$transform"` if test "x$STRIP_TRANSFORM_NAME" = x; then STRIP_TRANSFORM_NAME=strip fi [... same for readelf, as and nm] And then I will push the patches to trunk. Later I will send a separated patch with the addition of GDB_AC_TRANSFORM for Pedro's consideration. Salud!