From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63509 invoked by alias); 13 Dec 2016 13:26:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63487 invoked by uid 89); 13 Dec 2016 13:26:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy1.mail.unifiedlayer.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO gproxy1.mail.unifiedlayer.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Dec 2016 13:25:55 +0000 Received: from cmgw3 (cmgw4 [10.0.90.84]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id 9706B1767AC for ; Tue, 13 Dec 2016 06:25:54 -0700 (MST) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id KRRr1u00l2f2jeq01RRuUT; Tue, 13 Dec 2016 06:25:54 -0700 X-Authority-Analysis: v=2.1 cv=G8WPTbU5 c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n5n_aSjo0skA:10 a=20KFwNOVAAAA:8 a=UoRZ8S-H2Z5sz-Ac7voA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 70-58-1-248.hlrn.qwest.net ([70.58.1.248]:37396 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cGn5b-0007D9-7t; Tue, 13 Dec 2016 06:25:51 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 2/8] Use class to manage BFD reference counts References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-3-git-send-email-tom@tromey.com> Date: Tue, 13 Dec 2016 13:26:00 -0000 In-Reply-To: (Pedro Alves's message of "Fri, 2 Dec 2016 13:05:20 +0000") Message-ID: <87fulseza9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cGn5b-0007D9-7t X-Source-Sender: 70-58-1-248.hlrn.qwest.net (bapiya) [70.58.1.248]:37396 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-12/txt/msg00288.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> - return NULL; >> + return gdb_bfd_ref_ptr (); Pedro> This provides a good reason to have an implicit construction from Pedro> nullptr_t. You had it in the original gdbpy_reference Pedro> submission, but I had asked to remove it. If we add it back, Pedro> these cases could be more clearly written as "return Pedro> NULL/nullptr". Could you do that, and then drop all the hunks Pedro> like: >> - return NULL; >> + return gdb_bfd_ref_ptr (); Pedro> ? I did this. Pedro> I think these could be: Pedro> std::string filename Pedro> = string_printf ("%.*s", filename_len, pathname); Pedro> std::string member_name Pedro> = string_printf ("%.*s", path_len - filename_len - 2, sep + 1)); I did this, but it's a bit ugly as solib_find isn't const-correct. I'll send a new patch soon. Tom