Re: [PATCH] PR cli/21688: Fix multi-line/inline command differentiation

Simon Marchi
2017-06-29T21:06:32Z

On 2017-06-29 21:48, Sergio Durigan Junior wrote:
> On Thursday, June 29 2017, Simon Marchi wrote:
>> Another (maybe simpler) way would be to check
>>
>> else if (command_name_equals (cmd, "python") && *cmd_name == '\0')
>>
>> It's not clear when expressed like this though because cmd_name is not
>> well named at this point (it points just after the command name).
>
> Hm, right. Would you prefer this way instead? I don't have a strong
> opinion on this.

My opinion is the solution with the least code is probably best, if they
are equivalent otherwise, but I don't really mind. It's just a
suggestion.

Simon