From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95097 invoked by alias); 22 Sep 2017 18:33:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95080 invoked by uid 89); 22 Sep 2017 18:33:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 18:33:21 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3E6681F58B for ; Fri, 22 Sep 2017 18:33:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3E6681F58B Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1493B65E96; Fri, 22 Sep 2017 18:33:20 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH v2 5/5] Extend "set cwd" to work on gdbserver References: <20170912042325.14927-1-sergiodj@redhat.com> <20170919042842.9210-1-sergiodj@redhat.com> <20170919042842.9210-6-sergiodj@redhat.com> <2a0b74f9-d0e8-cd82-dfcc-9b2459a79c53@redhat.com> <87shfh3p8y.fsf@redhat.com> Date: Fri, 22 Sep 2017 18:33:00 -0000 In-Reply-To: (Pedro Alves's message of "Fri, 22 Sep 2017 11:47:12 +0100") Message-ID: <87fube1t3k.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00691.txt.bz2 On Friday, September 22 2017, Pedro Alves wrote: > On 09/21/2017 12:49 AM, Sergio Durigan Junior wrote: >> On Wednesday, September 20 2017, Pedro Alves wrote: > >>> This all looks stale to me. >> >> Indeed, sorry about this mistake. I will rewrite the entry as follows: >> >> * New features in the GDB remote stub, GDBserver >> >> ** GDBserver is now able to enter a directory before starting an >> inferior. >> >> The user can set the desired working directory to be used by the >> remote inferior on GDB, using the new "set cwd" command, which >> will instruct GDB to tell GDBserver about this directory change >> the next time an inferior is run. > > I still think this is talking too much in terms of implementation > detail, but I'll reply again to v3. I'm curious to know why. I'll wait for your review. >> In this case, I'd have to check for ![is_remote host], is that right? >> >>> I don't understand the explicit check for gdbserver in >>> skip_gdbserver_tests. >> >> I was thinking of the following scenario: >> >> - The users wants to skip gdbserver tests >> >> - He runs the test as "make check-gdb TESTS=gdb.base/set-cwd.exp" >> >> - Because of the unconditional call to "skip_gdbserver_tests", the test >> doesn't run at all, even though the test *should* run because the user >> hasn't specified any remote board, etc. > > And that's what I don't understand at all. skip_gdbserver_tests > is useful for the gdb.server/ tests that spawn gdbserver even > if testing with the local/unix board, i.e., the native target. > But this testcase isn't spawning gdbserver manually, unlike e.g., the > gdb.server/ tests. It just runs against whatever target is > specified by --target_board. Ah. Then I *really* misunderstood these concepts. Thanks for clarifying this to me. v3 still has the call to "skip_gdbserver_tests", so please ignore it. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/