From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14101 invoked by alias); 9 Jul 2018 23:13:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14091 invoked by uid 89); 9 Jul 2018 23:13:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.198.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jul 2018 23:13:15 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 1AF11400F9933 for ; Mon, 9 Jul 2018 17:10:29 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cfH5fdjILaSeycfHLfH91H; Mon, 09 Jul 2018 18:09:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2Obzze3yXWly3/bE/0IVNmWrJvKWSlA/8qascsELucU=; b=LPlTRE65j5Ou/BvG9ADFvutYzv eqRssBCCOzdmRDvItCAGMHXVmEHEYCrSX2harursTzeo9Amks69pKn/p+7Glegp69Ns4JnmWnY4LT MVjMiGPszA/TYyRBXO8XmKmN2; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:47050 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fcfH5-002Y7j-AD; Mon, 09 Jul 2018 18:08:55 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 16/42] Use gdb_assert in two places in buildsym.c References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-17-tom@tromey.com> Date: Mon, 09 Jul 2018 23:13:00 -0000 In-Reply-To: (Simon Marchi's message of "Sun, 8 Jul 2018 12:55:53 -0400") Message-ID: <87fu0sovll.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00234.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Just a nit, but I think inverting the condition would be more readable Simon> gdb_assert (current_subfile != NULL && current_subfile->name != NULL); Simon> LGTM either way. I did this. Tom