Re: [PATCH 2/2] gdb: Allow parenthesis to group arguments to user-defined commands

Tom Tromey
2018-08-28T15:54:21Z

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> So, my suggestion deliberately avoids using quotes or backslashes as
Andrew> these are bogged down in the existing code. And using (...) is fairly
Andrew> intuitive given GDBs C like expression handling, personally I'd rather
Andrew> write:
Andrew> my_command ({unsigned long long} &global_var)
Andrew> than:
Andrew> my_command {unsigned\ long\ long}\ &global_var

FWIW I tend to agree with your logic here.

User-defined argument parsing is broken (and I think there's at least
one bug in bugzilla about this), but at the same time, making breaking
changes seems unfriendly. Your approach doesn't seem to be breaking
anything that is likely to be actually used.

Tom