From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111905 invoked by alias); 19 Sep 2018 14:36:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111863 invoked by uid 89); 19 Sep 2018 14:36:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=wholly X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (50.116.126.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Sep 2018 14:36:30 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id AEA0B78F7E for ; Wed, 19 Sep 2018 09:36:28 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2daegxFNdBcCX2daegLl3W; Wed, 19 Sep 2018 09:36:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rmx5Kex+M5XWS59U+hKFW/wQTROtvzSdzKc9hSgM8mY=; b=ItFygvBJDhL+dR/zcTIMhuS90o BRg9NYAhNLDKb0ZfpHwm3Y1l/y5y7Kh1E6lyOwuaemM8gAW7Lxl2niyW92tLHH2Mb/sLjJpArO9BS XgIkPp3foFjALokizlYpuvzTy; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:54898 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g2dae-002Wo1-4r; Wed, 19 Sep 2018 09:36:28 -0500 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , Simon Marchi , Xavier Roirand , gdb-patches@sourceware.org Subject: Re: [RFA 2/5] Darwin: Handle unrelocated dyld. References: <1534932677-9496-1-git-send-email-roirand@adacore.com> <1534932677-9496-3-git-send-email-roirand@adacore.com> <18e995c1bee8c82df212dd431136d259@polymtl.ca> <87lg7ysdpb.fsf@tromey.com> <20180919134057.GN19172@adacore.com> Date: Wed, 19 Sep 2018 14:36:00 -0000 In-Reply-To: <20180919134057.GN19172@adacore.com> (Joel Brobecker's message of "Wed, 19 Sep 2018 06:40:57 -0700") Message-ID: <87fty5r1ud.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00689.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> + (Apparently dyld doesn't need to relocate itself on x86-64 darwin, >> + but don't assume that). Joel> I am wondering whether the difference in what you are seeing Joel> might be explained by a difference in MacOS X version; if I were Joel> to guess, I would say that Xavier was running on Mac OS X Sierra. Joel> What version were you running on? High Sierra. Joel> Or perhaps the intent is to be extra careful meaning that while Joel> today the relocation is not necessary, we still handle it so that Joel> it continues working the day it becomes so? I couldn't really say, I just concluded what I did based on the mention of the specific architecture there. Joel> If the comment above is confusing, I would vote for removing it. I think we need more information. If we remove the comment because we think it is untrue, then Simon's original critique of the patch -- that there is no reason for a second solib breakpoint -- seems correct. And in this case we should remove a chunk of the patch. Based on my testing thus far, this would be fine. But I don't know what testing Xavier and Tristan did, or with what architectures. Also my testing hasn't been exactly exhaustive. I just try simple things because today those break. Now, for my purposes, it would be fine to land the more minimal patch. That would not preclude adding this code back later. If that seems ok, I'm happy to do it. I'd like to get this working so I can make some progress on other patches, and anyway un-break the Mac port. Joel> That makes me realize (again) that, for MacOS X, we should be more Joel> proactive at specificying which version a patch we are submitting Joel> was tested on, and some information about which versions of MacOS X Joel> a given patch helps. A fair amount of work that Tristan did once Joel> the initial port was created was to adapt it to subsequent versions Joel> of Darwin. Nearly every new version of Darwin introduced its new Joel> set of changes requiring additional adaptations. Wholly agreed. Tom