From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92570 invoked by alias); 29 Nov 2018 18:13:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92520 invoked by uid 89); 29 Nov 2018 18:13:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Philippe, transfer X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.185.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 18:13:04 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 7B54C40148A88 for ; Thu, 29 Nov 2018 11:22:39 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id SQo8gu6ZdPvAdSQo8gZcA4; Thu, 29 Nov 2018 12:13:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wOFIqzRPDN75gm8IjiikUu5JRYCbofYUdadp8f3qmOI=; b=wMgApfQUSSGJTcl2sex8uz3wTe iRPn5MftxpJWXHNBIm+gRPsTmvRVz1jkhPQR2EINBd6pxeKwDJN59QgoUNY/Br1Y+pF+ofI30MiYW tfTSBT6Q5V0jldpiYQ6uf2/u/; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:32960 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gSQo8-0016M0-IY; Thu, 29 Nov 2018 12:13:00 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [PUSHED/OBVIOUS] Re-fix leak in source.c (open_source_file). References: <20181124115237.8943-1-philippe.waroquiers@skynet.be> Date: Thu, 29 Nov 2018 18:13:00 -0000 In-Reply-To: <20181124115237.8943-1-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 24 Nov 2018 12:52:37 +0100") Message-ID: <87ftvjbvmc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00542.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> Leak fixed in '8e6a5953e1d Fix 4K leak in open_source_file' has been partially Philippe> undone by '2179fbc36d23 Return scoped_fd from open_source_file'. Re-add the Philippe> transfer of current s->fullname to the unique_xmalloc_ptr fullname given to Philippe> find_and_open_source. Sorry about that, and thank you for fixing it. Tom