From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68912 invoked by alias); 30 Nov 2018 17:52:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68888 invoked by uid 89); 30 Nov 2018 17:52:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.60) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Nov 2018 17:52:23 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 4841221707 for ; Fri, 30 Nov 2018 11:52:22 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id SmxigoaVGkBj6SmxigkT1x; Fri, 30 Nov 2018 11:52:22 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OTbWjY1apGTLhIpyENmvGFnfSJ6p5seB0SBoy8U01pg=; b=sU3S8AB9EoPEQ7vhQjzq3IzCLE 4wdEW1Emg8R3iSwohfBaH3e3A8pKKGGw/objOmo5V7owGTmTaOuUXjnTUU5MSnDhScL8BmWWGR0U/ SxWwOb3PXSLRC/FEOlbkZJmJm; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:60956 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gSmxh-001gAn-VE; Fri, 30 Nov 2018 11:52:22 -0600 From: Tom Tromey To: Sergio Durigan Junior Cc: GDB Patches , Keith Seitz , Tom Tromey , Jan Kratochvil Subject: Re: [RFC/PATCH] Fix dwarf2read.c:dwarf2_find_containing_comp_unit's binary search References: <20181130172148.18830-1-sergiodj@redhat.com> Date: Fri, 30 Nov 2018 17:52:00 -0000 In-Reply-To: <20181130172148.18830-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Fri, 30 Nov 2018 12:21:48 -0500") Message-ID: <87ftvi1mi3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00576.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> https://bugzilla.redhat.com/show_bug.cgi?id=1613614 Sergio> * dwarf2read.c (dwarf2_find_containing_comp_unit): Add Sergio> 'mid_cu->length' to '*cu_off' when checking if 'sect_off' is Sergio> inside the CU. Thanks for the extensive analysis. I agree this is correct; please check this in. It's weird that cu_off is a pointer in this code. It seems like that local could be removed entirely. But, no need to do that in this patch. Tom