From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119589 invoked by alias); 12 Jan 2019 15:54:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119529 invoked by uid 89); 12 Jan 2019 15:54:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=interest X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Jan 2019 15:54:25 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 7A235580A for ; Sat, 12 Jan 2019 09:54:23 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id iLc7gYbjrYTGMiLc7gJGY2; Sat, 12 Jan 2019 09:54:23 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ybypb4lAklB3G08PTCtn5ixZEUJM/9VW3kePrwTBphA=; b=SmC6l1Esxu3g8mlfK2V3F1MN3z PYSpaMtHur38DKZ6IpLafBXexNjp66lqDSR6zkr4oqYaNbRRhzGV5UsBhUknWFjsqp9AoGRha7b+j 1t1+dT3F/A519ptpykZ+1z6LT; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:37966 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1giLc7-001xNr-17; Sat, 12 Jan 2019 09:54:23 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 00/12] remove some cleanups using a cleanup function References: <20190109033426.16062-1-tom@tromey.com> Date: Sat, 12 Jan 2019 15:54:00 -0000 In-Reply-To: (Andrew Burgess's message of "Sat, 12 Jan 2019 11:50:33 +0000") Message-ID: <87fttxx45t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00280.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> The cleanup_function class can take any number of arguments, and is Andrew> cancellable if needed, it can also take zero arguments. In theory Andrew> this would allow any cleanup that only needs to hold some simple Andrew> arguments by value and call a static function to be made into a Andrew> `cleanup_function` specialisation. It seems reasonable to me. I think the advantage it has over my approach is that the resulting classes are more similar to what we would have written had we implemented a custom class to replace each cleanup. Also it helps enforce the idea that we don't want cleanup_functions to be used in an unrestricted way. Andrew> How do you think this compares to your original patches? Any interest Andrew> in this approach? Yes, let's do this. Tom