From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11812 invoked by alias); 24 Apr 2019 19:32:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11802 invoked by uid 89); 24 Apr 2019 19:32:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=Youll, You'll, took X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.48.251) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Apr 2019 19:32:17 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 8FBB211B3D for ; Wed, 24 Apr 2019 14:32:16 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id JNcuhHRrCYTGMJNcuhNULX; Wed, 24 Apr 2019 14:32:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n8ptBBsQhC7AnO6zeddLtYoF5S7xGPu6mRo1EnzZKEk=; b=ysS4TNuqUvI9pDLUTkU1i2hRBG Z2vL2XTLjr3aakjd/Q+Ajql9AphMPh3hIECerUa0L0pg2zAo3ZXX8NQzXLyaz28ggZTZIz5IDpduM Cg4wSkheFqFNOP0tuMlL3Zd7F; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:54612 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hJNcu-003fOw-Bc; Wed, 24 Apr 2019 14:32:16 -0500 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCHv2 4/5] gdb: Introduce new language field la_is_string_type_p References: <878sw6dpg0.fsf@tromey.com> <20190419222203.GW2737@embecosm.com> Date: Wed, 24 Apr 2019 19:32:00 -0000 In-Reply-To: <20190419222203.GW2737@embecosm.com> (Andrew Burgess's message of "Fri, 19 Apr 2019 23:22:03 +0100") Message-ID: <87ftq7fbcw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00494.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> ...but, after prompting, I took a closer look, and rust_slice_type_p Andrew> is only true for TYPE_CODE_STRUCT, which makes the union check Andrew> redundant - so its gone! Thanks. >> Also, I think an array or slice of 'char' should probably be considered >> a string in Rust. See rust_chartype_p. Andrew> That sounds sensible, but .... I don't believe these things that you Andrew> describe are currently printed as strings. Thanks for looking into that. Maybe it's just an oversight in the Rust code, or maybe it's just uncommon to do this kind of thing. Not your problem :) Andrew> You'll have noticed (maybe?) that the original patch didn't include a Andrew> rust test at all. This was because some of rusts value printing seems Andrew> a little broken right now. For example, printing an array slice Andrew> (&str) variable works fine, but place this inside a struct and it no Andrew> longer works, for example: Thanks for noticing that. I can deal with it, unless you want to. Andrew> So, I think the summary is, I'm happy to fix rust_is_string_p to cover Andrew> any cases that currently print as a string, but I think that if Andrew> something _doesn't_ currently print as a string then rust_is_string_p Andrew> shouldn't identify it as a string - if it did then we'd end up Andrew> printing a structure at a depth when it should have been replaced with Andrew> ellipsis. Agreed. Tom