From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109112 invoked by alias); 6 May 2019 13:57:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108755 invoked by uid 89); 6 May 2019 13:57:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_RP_RNBL,SPF_HELO_PASS autolearn=no version=3.3.1 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 May 2019 13:57:44 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id CC19D1A7E for ; Mon, 6 May 2019 08:57:42 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Ne7ihRV28iQerNe7ih6F8y; Mon, 06 May 2019 08:57:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HNHExxO1l1a5ginaHTyYCGtZBapngI2wQXr2nDiGe9A=; b=DS6lPYseDp051TuaYs+07udknt unCTGTN4GFmSocMEUPYSHIiADwBFOOAv+hPWpiV498fe0WPbbiO9yAwk1Pa/x37rvxeow/KOSFTvj JVMR2unP9OSbE4/0S2lEAzVTU; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:41002 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hNe7i-001Od7-JQ; Mon, 06 May 2019 08:57:42 -0500 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb: Convert dwarf2_evaluate_property to return bool References: <6833f5415d7c517b3fea172e3383d74563274e4f.1557088062.git.andrew.burgess@embecosm.com> Date: Mon, 06 May 2019 13:57:00 -0000 In-Reply-To: <6833f5415d7c517b3fea172e3383d74563274e4f.1557088062.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Sun, 5 May 2019 21:57:01 +0100") Message-ID: <87ftprofca.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00167.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> Convert dwarf2_evaluate_property to return a bool, there should be no Andrew> user visible change after this commit. Andrew> gdb/ChangeLog: Andrew> * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and Andrew> update return statements. Andrew> * dwarf2loc.h (dwarf2_evaluate_property): Update return type on Andrew> declaration, and update comment to match. Andrew> * gdbtypes.c (resolve_dynamic_array): Update call to Andrew> dwarf2_evaluate_property to match new return type. Thanks for the patch. This is ok. Tom