From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97349 invoked by alias); 28 Jun 2019 15:45:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97272 invoked by uid 89); 28 Jun 2019 15:45:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=stap-probe.c, stapprobec, 24541, H*Ad:U*fche X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.147.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Jun 2019 15:45:22 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id AD8A65B1 for ; Fri, 28 Jun 2019 10:45:20 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gt3whBZm7dnCegt3whkqG9; Fri, 28 Jun 2019 10:45:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PisudmkQ3R9lb6D4h/gvNiGiEbcy75MnJBWwP+65ZAs=; b=guAMK2fx0h7XCF34N9T89426oX s5v67aYApFvykctX5nM4ZSQJdpd1x9ZIL4lM0XLsm7Ssa5ice9/sYToWyC1ZS2jHpTG3hgu/ZCn8s PycCKkyewajVo0Ha10x5MxkCv; Received: from 75-166-12-78.hlrn.qwest.net ([75.166.12.78]:50772 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hgt3w-002ozf-DT; Fri, 28 Jun 2019 10:45:20 -0500 From: Tom Tromey To: Sergio Durigan Junior Cc: GDB Patches , andrew.burgess@embecosm.com, fche@redhat.com, jakub@redhat.com Subject: Re: [PATCH] Adjust i386 registers on SystemTap probes' arguments (PR breakpoints/24541) References: <20190626220031.6302-1-sergiodj@redhat.com> Date: Fri, 28 Jun 2019 15:45:00 -0000 In-Reply-To: <20190626220031.6302-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Wed, 26 Jun 2019 18:00:31 -0400") Message-ID: <87ftntzpbk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00636.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> gdb/ChangeLog: Sergio> 2019-06-27 Sergio Durigan Junior Sergio> * gdbarch.c: Regenerate. Sergio> * gdbarch.h: Regenerate. Sergio> * gdbarch.sh: Add 'stap_adjust_register'. Sergio> * i386-tdep.c: Include ''. Sergio> (i386_stap_adjust_register): New function. Sergio> (i386_elf_init_abi): Register 'i386_stap_adjust_register'. Sergio> * stap-probe.c (stap_parse_register_operand): Call Sergio> 'gdbarch_stap_adjust_register'. Thank you for the patch and the excellent explanation. This is ok. For a while I was updating some SystemTap wiki page to link to these kinds of bugs, so that anybody else interested in supporting these probes had a list of oddities to work from. This one would seem to qualify for that. Tom