From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85400 invoked by alias); 21 Aug 2019 19:11:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85392 invoked by uid 89); 21 Aug 2019 19:11:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Aug 2019 19:11:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B2E13116453; Wed, 21 Aug 2019 15:11:55 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NaVxnjUph48P; Wed, 21 Aug 2019 15:11:55 -0400 (EDT) Received: from murgatroyd (97-122-178-82.hlrn.qwest.net [97.122.178.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 38A4711643D; Wed, 21 Aug 2019 15:11:55 -0400 (EDT) From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/8] Handle copy relocations References: <20190801170412.5553-1-tromey@adacore.com> <20190801170412.5553-3-tromey@adacore.com> <20190821153528.GH6076@embecosm.com> Date: Wed, 21 Aug 2019 19:11:00 -0000 In-Reply-To: <20190821153528.GH6076@embecosm.com> (Andrew Burgess's message of "Wed, 21 Aug 2019 16:35:28 +0100") Message-ID: <87ftlul4ed.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00511.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: >> +struct minimal_symbol * >> +lookup_minimal_symbol_linkage (const char *name, struct objfile *objf) Andrew> I found the name chosen for this function rather confusing. When Andrew> comparing to say 'lookup_minimal_symbol_text' which does Andrew> sort-of-almost the same thing but for text type symbols, I might have Andrew> been tempted to go with 'lookup_minimal_symbol_data'. Am I missing Andrew> something behind the choice of function name? You aren't missing anything. lookup_minimal_symbol_data seems maybe confusing too, because lookup_minimal_symbol_text loops over all objfiles, but this one does not. I guess I don't care all that much (as evidenced by the original choice of name ;) so if you still like that better, I'll make the change. Tom