Re: [PATCH 1/3] Refactor get_init_files to use std::string

Tom Tromey
2019-09-10T15:02:31Z

>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

Christian> To avoid manual memory management.
Christian> Tested on buildbot.

Thank you for the patch.

Christian> + relocated_sysgdbinit = std::string (gdb_datadir) + SLASH_STRING +
Christian> + &SYSTEM_GDBINIT[start];

This needs parens around the RHS so that the indentation is correct
according to GNU standards.

Christian> + if (!relocated_sysgdbinit.empty () &&

&& on the start of a line, not the end.

This is ok with those nits fixed.

Tom