From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127057 invoked by alias); 19 Dec 2019 18:19:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127048 invoked by uid 89); 19 Dec 2019 18:19:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 18:19:30 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 056603F250 for ; Thu, 19 Dec 2019 12:19:29 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id i0OWiFwl9W4fri0OXiZeRV; Thu, 19 Dec 2019 12:19:29 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q4u5mYIuCC0RWDlQapbbfvwIQOyW5m9DU5AIiAsMr+8=; b=Uu6I0PTgPavynYmeNm1qsEr3+1 rVSjAtqwqMmztZRRHQ0KVh+E3q3yHdx3YArvty4ubaMFiJVI/xssNqU1xEWzLvPVYi/PDTjRKU6Db iLKUavTuBEd09TRkjGWkMnD53; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:37472 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ii0OW-00173x-Qp; Thu, 19 Dec 2019 11:19:28 -0700 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH 3/3] Make the literal argument to pow a double, not an integer References: <20191219000103.36667-1-cbiesinger@google.com> <20191219000103.36667-5-cbiesinger@google.com> Date: Thu, 19 Dec 2019 18:19:00 -0000 In-Reply-To: <20191219000103.36667-5-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Wed, 18 Dec 2019 18:01:03 -0600") Message-ID: <87fthgb2kv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00828.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> 2019-12-18 Christian Biesinger Christian> * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of Christian> 2 to pow (). It probably makes sense to add a comment about Solaris here as well. It's a bit borderline for me, considering it is a constant, but on the other hand, a comment is definitely safe. So, ok with that change. thanks, Tom