From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.196]) by sourceware.org (Postfix) with ESMTPS id 4E7393857C58 for ; Thu, 16 Jul 2020 20:12:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4E7393857C58 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id A51C0846F0 for ; Thu, 16 Jul 2020 15:12:25 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id wAEzjwB0bBb5dwAEzjpHlB; Thu, 16 Jul 2020 15:12:25 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WmYZ7UXa9wr5KegBJh8QrAvNo3iXqj0WXwMnjJI/NgU=; b=AwhdA3/aAfw0BA4JwNMwY6Hb2B /VfHe4J1jHA5CZs0pnpfyOBqowmLhPBnrMSTf4dCdOYgEnWyAbbOM6cHZ2li6OQIP0Zwfrj6NCiIE 0SAxM2wqXFgfSSVkjzUzKHJED; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:47186 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jwAEz-002erP-9X; Thu, 16 Jul 2020 14:12:25 -0600 From: Tom Tromey To: Joseph Myers Cc: Caroline Tice , Caroline Tice via Gdb-patches , Eric Christopher , Tom Tromey , Simon Marchi Subject: Re: [PATCH] Update testsuite mechanism to allow object files as source files. References: X-Attribution: Tom Date: Thu, 16 Jul 2020 14:12:23 -0600 In-Reply-To: (Joseph Myers's message of "Thu, 16 Jul 2020 17:33:28 +0000") Message-ID: <87ft9rmd7c.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jwAEz-002erP-9X X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:47186 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2020 20:12:28 -0000 Joseph> On general free software and reproducible builds principles: Joseph> * The source for any checked-in object file should be checked in. Joseph> * That source should include comments giving all information required to Joseph> be able to reproduce the object file byte-for-byte In the past we tried this kind of thing, by taking the assembly generated by the compiler, then editing it and checking it in. However, IMO, this turned out to be a pain. The hand editing was often not sufficiently documented, and the tests were still architecture-dependent. Once or twice I think someone has had to edit the .S file later, which is error-prone. Also, the earliest test suite additions like this didn't include the original source, making this harder to handle. The "DWARF assembler" in the test suite avoids all this, at least for tests that require particular debuginfo. The main drawbacks of this approach are (again IMO) that sometimes it's a pain to write the DWARF by hand, and that sometimes the assembler framework itself needs upgrades before one can even begin. However, the tests are much more robust. I'd encourage the extension of the latter approach as much as possible. It isn't perfect but IME has been better on the whole. Tom