From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id erzkCNjVkV/yRgAAWB0awg (envelope-from ) for ; Thu, 22 Oct 2020 14:56:24 -0400 Received: by simark.ca (Postfix, from userid 112) id 16B8C1E89B; Thu, 22 Oct 2020 14:56:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 773C31E552 for ; Thu, 22 Oct 2020 14:56:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2FE1C3857C4D; Thu, 22 Oct 2020 18:56:23 +0000 (GMT) Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.36]) by sourceware.org (Postfix) with ESMTPS id D70223857C4D for ; Thu, 22 Oct 2020 18:56:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D70223857C4D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 2603F511EE for ; Thu, 22 Oct 2020 13:56:19 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Vfl5k0IfZLFNkVfl5kuUjM; Thu, 22 Oct 2020 13:56:19 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8F/xWGAM1o2ZlwwJGedXnpCsOt4y9B2Ohbi28C7pNKE=; b=WPRr6gKRlaGPaH18KEWr/rBC/3 j4xzg7XaATCUX09YzxfS1N4GYmJGEHwq2LQ4j0dR3zy169sgGPE6mkvu19adNueQmDGngiNN/CoUM SUH33Zdi6E0neZD7xAKhz1C3o; Received: from 75-166-102-113.hlrn.qwest.net ([75.166.102.113]:33156 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kVfl4-003ou2-OS; Thu, 22 Oct 2020 12:56:18 -0600 From: Tom Tromey To: Tom de Vries Subject: Re: [committed][gdb/symtab] Make find_block_in_blockvector more robust References: <20201022152431.GA13910@delia> X-Attribution: Tom Date: Thu, 22 Oct 2020 12:56:17 -0600 In-Reply-To: <20201022152431.GA13910@delia> (Tom de Vries's message of "Thu, 22 Oct 2020 17:24:32 +0200") Message-ID: <87ft66144u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.102.113 X-Source-L: No X-Exim-ID: 1kVfl4-003ou2-OS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-102-113.hlrn.qwest.net (murgatroyd) [75.166.102.113]:33156 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> + if (!(BLOCK_START (b) <= pc)) Tom> + return NULL; This seems a bit weird to me, in that if BLOCK_START(b) == pc, then I would be inclined to say that the pc is in fact in that block. Tom