From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MDyhFkzH01/obQAAWB0awg (envelope-from ) for ; Fri, 11 Dec 2020 14:23:56 -0500 Received: by simark.ca (Postfix, from userid 112) id 50A501F0A9; Fri, 11 Dec 2020 14:23:56 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EC1441E590 for ; Fri, 11 Dec 2020 14:23:55 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A400C397302B; Fri, 11 Dec 2020 19:23:55 +0000 (GMT) Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.229]) by sourceware.org (Postfix) with ESMTPS id E72D3397302B for ; Fri, 11 Dec 2020 19:23:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E72D3397302B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id D46A11FEF7 for ; Fri, 11 Dec 2020 13:23:52 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id no1AkckbOoE4Dno1Ak64SK; Fri, 11 Dec 2020 13:23:52 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=46L2Y8oMeNHeUqsWWIpHralHY8h26vIPW5UkhF7q22M=; b=xmjnNglT4FT9jgDlkjE+ejoARW euubnVAjswcuXDr1Ig8XVgjzT1Y4UouuScoSpVVcMfzcTRsB2+PAtrnzr8d16VaopfkCIsx65V1BE ndxFXhblVw6sg2Dy1GLkS/V7v; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:40350 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kno1A-0044Mz-EO; Fri, 11 Dec 2020 12:23:52 -0700 From: Tom Tromey To: Tom de Vries Subject: Re: [PATCH] gdb: print size of downloaded debuginfod binary References: <6ad82f30-0ca3-8b19-2907-d71f0dfecafe@suse.cz> <2c28a403-a169-0dc3-9b64-58484237c8c2@suse.cz> <72061fbb-b480-04ce-ef4a-fe13a7266885@suse.de> <87a6ulmppr.fsf@tromey.com> <5506b198-c504-0046-0559-bcc24538d31c@suse.de> X-Attribution: Tom Date: Fri, 11 Dec 2020 12:23:51 -0700 In-Reply-To: (Tom de Vries's message of "Fri, 11 Dec 2020 18:54:43 +0100") Message-ID: <87ft4cgn94.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kno1A-0044Mz-EO X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:40350 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> + gdb::optional meter; Seems like a bit of a shame to have an optional here, but then essentially require optional-style behavior in the CLI ui-out as well (in deferring output until the first update). Maybe it could be done in progress_meter itself. Not sure. Tom> - /* Print this message only once. */ Tom> - data->has_printed = true; Tom> - printf_filtered ("Downloading %s %ps...\n", Tom> - data->desc, Tom> - styled_string (file_name_style.style (), data->fname)); Tom> + float size_in_mb = 1.0f * total / (1024 * 1024); Tom> + std::stringstream message; Tom> + message.precision (2); Tom> + message << "Downloading " << size_in_mb << " MB " << data->desc Tom> + << " " << data->fname; Seems like this could use string_printf. I suspect there's some way to preserve the styling but offhand I don't recall what it is. Maybe you have to use string_file to accomplish that. Tom