From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KmnVMXcqKGAbdwAAWB0awg (envelope-from ) for ; Sat, 13 Feb 2021 14:37:27 -0500 Received: by simark.ca (Postfix, from userid 112) id BD9CF1EF68; Sat, 13 Feb 2021 14:37:27 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 378491E789 for ; Sat, 13 Feb 2021 14:37:27 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3C35D3848012; Sat, 13 Feb 2021 19:37:26 +0000 (GMT) Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.38]) by sourceware.org (Postfix) with ESMTPS id 463CB3857005 for ; Sat, 13 Feb 2021 19:37:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 463CB3857005 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 95162400C80B8 for ; Sat, 13 Feb 2021 13:37:22 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id B0jKlU70rDT64B0jKlFWG5; Sat, 13 Feb 2021 13:37:22 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7VlDn6MR54tWcK+IsOb2A3eCxIVNaHsnr46KRK28FfE=; b=EIMm7CPMFo8NjiHKkB2TRRPrSR Mff9sSJbdAmEpq8A+9028oo2LfBckIioTh3881yKPdN87qf0+IE5QvNxYjjLTHjXBddGqDrX4Rl7Q tCrHPPyzg2Lq+mTa/gcrcWpak; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:52372 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lB0jJ-001PPi-Uh; Sat, 13 Feb 2021 12:37:22 -0700 From: Tom Tromey To: Andrew Burgess Subject: Re: [PATCH 003/203] Split out eval_op_var_msym_value References: <20210101214723.1784144-1-tom@tromey.com> <20210101214723.1784144-4-tom@tromey.com> <20210104114326.GW2945@embecosm.com> X-Attribution: Tom Date: Sat, 13 Feb 2021 12:37:20 -0700 In-Reply-To: <20210104114326.GW2945@embecosm.com> (Andrew Burgess's message of "Mon, 4 Jan 2021 11:43:26 +0000") Message-ID: <87ft1zvjwv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1lB0jJ-001PPi-Uh X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (localhost.localdomain) [97.122.91.54]:52372 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Andrew" == Andrew Burgess writes: >> >> +static struct value * >> +eval_op_var_msym_value (struct type *expect_type, struct expression *exp, >> + enum noside noside, >> + minimal_symbol *msymbol, struct objfile *objfile) Andrew> The first couple of patches included a header comment for these new Andrew> helper functions. Starting from this patch these header comments are Andrew> hit and miss. Andrew> Maybe these should be added? I haven't commented on each patch where Andrew> this is an issue, that didn't feel very helpful. I went through the "Split" patches and I've added comments where they were missing. Tom