From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xSUUFvSGe2IfnAUAWB0awg (envelope-from ) for ; Wed, 11 May 2022 05:50:44 -0400 Received: by simark.ca (Postfix, from userid 112) id E64951E21F; Wed, 11 May 2022 05:50:39 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=AT5u7NWB; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B27401E00D for ; Wed, 11 May 2022 05:50:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3868E395B818 for ; Wed, 11 May 2022 09:50:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3868E395B818 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652262631; bh=JE3KZPZCJHWkDB3y7gP0N7wQOLRe8ljhBEE4PIh/LCo=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=AT5u7NWBPZw6YocEuXoDeWsDQzK6Vr+kN8Va8QJSq6X9GJQ5tifiocCTg+w03W2sJ xTwpbof2HcErRZn3o67egq3/xlvw/dUhh7D+z46qlTO8MoT2w5d/07JZAZcTcMF5/g tRM/+kewaz7gDwxqwCE8AKl66s9dgc+Peyn+YkBk= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0A019395B45B for ; Wed, 11 May 2022 09:49:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A019395B45B Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-141-SJvpT_S7MuSf7ShZ8tKqRg-1; Wed, 11 May 2022 05:49:51 -0400 X-MC-Unique: SJvpT_S7MuSf7ShZ8tKqRg-1 Received: by mail-wr1-f72.google.com with SMTP id j21-20020adfa555000000b0020adb9ac14fso628182wrb.13 for ; Wed, 11 May 2022 02:49:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=JE3KZPZCJHWkDB3y7gP0N7wQOLRe8ljhBEE4PIh/LCo=; b=7IjbLPDRqGR7JR3v6uIF/QfsohfvJGFzWmeMauZ5sBe2fVBaHWo6EK8XCT94C16RBN nVFc25OZLA6ZhPxj1nU7NJaWbT5UL/JdUGBWLqNy0iJMYl7IfACCnOkOAw0GhoiV6YyJ YQG4USdNoxAZtbQTcb1aUNFB/fex5uiuvNPfxnUkTQHPW6pZbvYbL0N97TrOPVOMD836 KB69wAdDOHo/PPAApwx1f8Pzoyy+GGvD7nMlE4VNWCzg/CAef/YGATQ4pARm4x8efpD1 012khNwlHJ9CJGb2yjx8oom7I7CNnvw3hVpLRPCo9uQfPlXcogQDazNpA3tUdpiH4wTU /M3w== X-Gm-Message-State: AOAM53219vl3M92BYKN6COHjAxisDYmEzPY+16mTwc9nakq9z1sN8Lb7 4qCiWGSafjXQduH6HEqbu1POAs756PK+ISTZq9hsjMekTOcy2eHFJ2mmpKzGQU5Au3PDJcLdWAq /GrXKhYon/DuqdAgttebyMA== X-Received: by 2002:a5d:52ce:0:b0:20c:e030:b05a with SMTP id r14-20020a5d52ce000000b0020ce030b05amr877184wrv.174.1652262590495; Wed, 11 May 2022 02:49:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzdkJzvmhvgl4HvcN+6gyXRTd+sU863s7yH3pqrD3t6i9anqgQXYWY7DlWm4jcqmsGCJodhhg== X-Received: by 2002:a5d:52ce:0:b0:20c:e030:b05a with SMTP id r14-20020a5d52ce000000b0020ce030b05amr877167wrv.174.1652262590271; Wed, 11 May 2022 02:49:50 -0700 (PDT) Received: from localhost (host81-136-113-48.range81-136.btcentralplus.com. [81.136.113.48]) by smtp.gmail.com with ESMTPSA id l9-20020a5d4109000000b0020c5253d8e1sm1449967wrp.45.2022.05.11.02.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 02:49:49 -0700 (PDT) To: Nils-Christian Kempke , gdb-patches@sourceware.org Subject: Re: [PATCH 03/18] gdb/testsuite: Fix fortran types for Intel compilers. In-Reply-To: <20220510142437.1397399-4-nils-christian.kempke@intel.com> References: <20220510142437.1397399-1-nils-christian.kempke@intel.com> <20220510142437.1397399-4-nils-christian.kempke@intel.com> Date: Wed, 11 May 2022 10:49:48 +0100 Message-ID: <87fslgl7pf.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: JiniSusan.George@amd.com, Abdul Basit Ijaz Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Nils-Christian Kempke via Gdb-patches writes: > From: Felix Willgerodt > > Newer Intel compilers emit their dwarf type name in a slightly different > format. Therefore, this needs adjustment to make more tests pass in the > Fortran testsuite. The change itself looks fine, but I don't understand the following: > There was not yet a way to handle the print for > variable length strings to this commit introduces fortran_integerN as > well. I suspect there's just a little context missing behind this. Thanks, Andrew > > Co-authored-by: Abdul Basit Ijaz > Co-authored-by: Nils-Christian Kempke > --- > gdb/testsuite/lib/fortran.exp | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/gdb/testsuite/lib/fortran.exp b/gdb/testsuite/lib/fortran.exp > index a97c6eeb4e..9531d393a1 100644 > --- a/gdb/testsuite/lib/fortran.exp > +++ b/gdb/testsuite/lib/fortran.exp > @@ -38,6 +38,8 @@ proc fortran_int4 {} { > return "integer" > } elseif {[test_compiler_info {icc-*}]} { > return "INTEGER\\(4\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "INTEGER\\*4" > } else { > return "unknown" > } > @@ -52,6 +54,8 @@ proc fortran_int8 {} { > return "integer\\*8" > } elseif {[test_compiler_info {icc-*}]} { > return "INTEGER\\(8\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "INTEGER\\*8" > } else { > return "unknown" > } > @@ -66,6 +70,8 @@ proc fortran_real4 {} { > return "real" > } elseif {[test_compiler_info {icc-*}]} { > return "REAL\\(4\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "REAL\\*4" > } else { > return "unknown" > } > @@ -80,6 +86,8 @@ proc fortran_real8 {} { > return "double precision" > } elseif {[test_compiler_info {icc-*}]} { > return "REAL\\(8\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "REAL\\*8" > } else { > return "unknown" > } > @@ -94,6 +102,8 @@ proc fortran_complex4 {} { > return "complex" > } elseif {[test_compiler_info {icc-*}]} { > return "COMPLEX\\(4\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "COMPLEX\\*8" > } else { > return "unknown" > } > @@ -108,6 +118,8 @@ proc fortran_complex8 {} { > return "double complex" > } elseif {[test_compiler_info {icc-*}]} { > return "COMPLEX\\(8\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "COMPLEX\\*16" > } else { > return "unknown" > } > @@ -122,6 +134,8 @@ proc fortran_complex16 {} { > return "quad complex" > } elseif {[test_compiler_info {icc-*}]} { > return "COMPLEX\\(16\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "COMPLEX\\*32" > } else { > return "unknown" > } > @@ -136,6 +150,8 @@ proc fortran_logical4 {} { > return "logical" > } elseif {[test_compiler_info {icc-*}]} { > return "LOGICAL\\(4\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "LOGICAL\\*4" > } else { > return "unknown" > } > @@ -150,6 +166,8 @@ proc fortran_character1 {} { > return "character" > } elseif {[test_compiler_info {icc-*}]} { > return "CHARACTER\\(1\\)" > + } elseif {[test_compiler_info {intel-*}]} { > + return "CHARACTER\\*1" > } else { > return "unknown" > } > -- > 2.25.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928