From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zHngHLhNTGTLBTkAWB0awg (envelope-from ) for ; Fri, 28 Apr 2023 18:50:32 -0400 Received: by simark.ca (Postfix, from userid 112) id 66E691E221; Fri, 28 Apr 2023 18:50:32 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=SYyPS0KI; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1E70E1E128 for ; Fri, 28 Apr 2023 18:50:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C4D6C3858C20 for ; Fri, 28 Apr 2023 22:50:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C4D6C3858C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682722230; bh=Awx8aWkYyBUrjNP/Rvd48XoYb7hNK/LSYsfGikF9y9I=; h=To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=SYyPS0KIBDDSn2rrAKHYXDT5IEyJeIFoIJ1WyJiliPOLKQAkoJfkgQB2YEK0gHdLI NJcUVX/RPoYs2GF5nk1YgxSJ+BG3Vx5KqdtKyZ3ZxchzFLzIaijglus+Jbf20SmkRB gEXv1YkI1iRC5/DqBaSdR8KsdSPSITv7N4kgS6wQ= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0FC3F3858C50 for ; Fri, 28 Apr 2023 22:49:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FC3F3858C50 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-492-x1GBnFwJNHyJ6hcuon-1aw-1; Fri, 28 Apr 2023 18:49:09 -0400 X-MC-Unique: x1GBnFwJNHyJ6hcuon-1aw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f18c2b2110so637185e9.3 for ; Fri, 28 Apr 2023 15:49:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682722148; x=1685314148; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Awx8aWkYyBUrjNP/Rvd48XoYb7hNK/LSYsfGikF9y9I=; b=ghBbbBOHgySxOordbAMWtzc++FQY5AK0xY901g6mlUYf3beVsbT2Zp9m6npDGO2mFW eiibz6sB1BJvbgIlqriV/oauEorHPucUZ5AekWcKzKONfaSO/u7O3a0a7wQYcjM+Q2Zq yxJzQLMmE7060Z7o3LTKbaWyYCyFCs/uoz0XAA3oWfYT3mtuzp8Uka9xNGg2GkdysCUD 5FojDZjpyWkIvSfyY2UsgU2u4QCUqGiHjnpHSG+Ot549gHNbxnuNCmAWBOKSycaIYlZu mQZOFkFRnCFhjCGuD7suW68PLpOy2i30t696rR2gVDPfdmlYlLCj0B3ibh8nBbBQkJPY gUlw== X-Gm-Message-State: AC+VfDyjQS6dchhIkwNSXscYz4LB0LCf0JE5D9e+22y3h0ooFe6vaNUk K1g389WptYIWfhXiaSufsi+Qim2fykmQ19NQ4z5MvXmt7EM6qy3x1Matto8G3MIwuBwxiU9Wewd aafpTtsdzY+Vbt5S1ddFvbB5vPbrj3Q== X-Received: by 2002:a1c:6a14:0:b0:3ed:514d:e07f with SMTP id f20-20020a1c6a14000000b003ed514de07fmr5665245wmc.3.1682722147930; Fri, 28 Apr 2023 15:49:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4wwbd04/lY4OSL5dlcOFKvIVtZ6p1wd03FNDMfEPDCxVSaCMe3i3mvOuSRZDikBvquSBAAgQ== X-Received: by 2002:a1c:6a14:0:b0:3ed:514d:e07f with SMTP id f20-20020a1c6a14000000b003ed514de07fmr5665240wmc.3.1682722147672; Fri, 28 Apr 2023 15:49:07 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id iz14-20020a05600c554e00b003f175954e71sm28876543wmb.32.2023.04.28.15.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 15:49:07 -0700 (PDT) To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/5] gdb/doc: improve Python Disassembler API documentation In-Reply-To: <83y1n7ubex.fsf@gnu.org> References: <3cdddabce2d5acfbdb9a8c5bdcb1a205a2bd01e5.1680596378.git.aburgess@redhat.com> <83y1n7ubex.fsf@gnu.org> Date: Fri, 28 Apr 2023 23:49:06 +0100 Message-ID: <87fs8jaahp.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Eli Zaretskii writes: >> Cc: Andrew Burgess >> Date: Tue, 4 Apr 2023 09:21:03 +0100 >> From: Andrew Burgess via Gdb-patches >> >> --- a/gdb/doc/python.texi >> +++ b/gdb/doc/python.texi >> @@ -6909,7 +6909,7 @@ >> @code{RuntimeError} exception if it is invalid. >> @end defun >> >> -@defun DisassembleInfo.__init__ (info) >> +@defun DisassembleInfo.__init__ (@var{info}) > > You consistently rewrite the Texinfo source to use @var inside the > argument lists of a @defun. I already asked why, as I don't think > this is required. I don't think you replied. So once again: why are > you doing this? what problems happen if you don't? This is an unfortunate consequence of me posting many patches in similar areas of GDB. All of these landed on the list prior to you enlightening me that @var is not needed -- it's not me ignoring you. I should have been more proactive in reviewing my in-flight patches for this error to avoid wasting your time. This change will, of course, be removed from this patch. Thanks for your patience, Andrew > > Otherwise, this is fine. Thanks. > > Reviewed-By: Eli Zaretskii